Bug 1134598 - Enable the vertical writing-mode reftest directory. r=smontagu
☠☠ backed out by 50752f206a9b ☠ ☠
authorJonathan Kew <jkew@mozilla.com>
Thu, 19 Feb 2015 13:37:42 +0000
changeset 230269 e37d57033b134ed9e673495ee5ba490ab336736e
parent 230268 38c14390bd27e7bb6760e32f9362cb6e524eac3f
child 230270 425c5e3af02458ad51eafe594eb7f5bcec61106d
push id55950
push userjkew@mozilla.com
push dateMon, 23 Feb 2015 09:02:46 +0000
treeherdermozilla-inbound@e37d57033b13 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmontagu
bugs1134598
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1134598 - Enable the vertical writing-mode reftest directory. r=smontagu
layout/reftests/reftest.list
layout/reftests/writing-mode/reftest.list
layout/reftests/writing-mode/ua-style-sheet-input-number-1-ref.html
layout/reftests/writing-mode/ua-style-sheet-input-number-1.html
--- a/layout/reftests/reftest.list
+++ b/layout/reftests/reftest.list
@@ -362,16 +362,19 @@ include xul-document-load/reftest.list
 include xul/reftest.list
 
 # xul
 include ../xul/reftest/reftest.list
 
 # xul grid
 include ../xul/grid/reftests/reftest.list
 
+# writing-mode
+include writing-mode/reftest.list
+
 # z-index/
 include z-index/reftest.list
 
 # reftest(s) to verify content bugfixes
 include ../../dom/html/reftests/reftest.list
 include ../../dom/imptests/reftest.list
 
 # editor/
--- a/layout/reftests/writing-mode/reftest.list
+++ b/layout/reftests/writing-mode/reftest.list
@@ -1,11 +1,12 @@
-# This directory contains tests for vertical text and logical layout coordinates
-# It should not be included in layout/reftests/reftest.list until vertical layout
-# is turned on
+# This directory contains tests for vertical text and logical layout coordinates.
+# They require the vertical-text pref to be true, otherwise lots of them will fail.
+default-preferences pref(layout.css.vertical-text.enabled,true)
+
 HTTP(..) == 1079154-1-vertical-rl-columns.html 1079154-1-vertical-rl-columns-ref.html
 == 1082844.html 1082844-ref.html
 HTTP(..) == 1083748.html 1083748-ref.html
 HTTP(..) == 1083848-1-inline-border.html 1083848-1-inline-border-ref.html
 HTTP(..) == 1083848-2-inline-background.html 1083848-2-inline-background-ref.html
 fuzzy-if(gtk2Widget,255,2) fuzzy-if(winWidget||Android||B2G,4,8704) HTTP(..) == 1083848-3-inline-background-repeat.html 1083848-3-inline-background-repeat-ref.html
 == 1083892-1.html 1083892-1-ref.html
 == 1086883-1a.html 1086883-1-ref.html
@@ -65,17 +66,18 @@ fuzzy(116,64) HTTP(..) == 1115916-1-vert
 == ua-style-sheet-fieldset-1.html ua-style-sheet-fieldset-1-ref.html
 skip-if(Android||B2G||(winWidget&&!/^Windows\x20NT\x205\.1/.test(http.oscpu))) == ua-style-sheet-textarea-1.html ua-style-sheet-textarea-1a-ref.html
 skip-if(!(Android||B2G)) == ua-style-sheet-textarea-1.html ua-style-sheet-textarea-1b-ref.html
 skip-if(!winWidget||/^Windows\x20NT\x205\.1/.test(http.oscpu)) == ua-style-sheet-textarea-1.html ua-style-sheet-textarea-1c-ref.html
 == ua-style-sheet-checkbox-radio-1.html ua-style-sheet-checkbox-radio-1-ref.html
 skip-if(Android||B2G) == ua-style-sheet-button-1.html ua-style-sheet-button-1a-ref.html
 skip-if(!(Android||B2G)) == ua-style-sheet-button-1.html ua-style-sheet-button-1b-ref.html
 == ua-style-sheet-input-color-1.html ua-style-sheet-input-color-1-ref.html
-fails == ua-style-sheet-input-number-1.html ua-style-sheet-input-number-1-ref.html # bug 1123299
+== ua-style-sheet-input-number-1.html ua-style-sheet-input-number-1-ref.html
+
 HTTP(..) == 1127488-align-default-horizontal-tb-ltr.html 1127488-align-top-left-ref.html
 HTTP(..) == 1127488-align-start-horizontal-tb-ltr.html 1127488-align-top-left-ref.html
 HTTP(..) == 1127488-align-end-horizontal-tb-ltr.html 1127488-align-top-right-ref.html
 HTTP(..) == 1127488-align-left-horizontal-tb-ltr.html 1127488-align-top-left-ref.html
 HTTP(..) == 1127488-align-right-horizontal-tb-ltr.html 1127488-align-top-right-ref.html
 HTTP(..) == 1127488-align-default-horizontal-tb-rtl.html 1127488-align-top-right-ref.html
 HTTP(..) == 1127488-align-start-horizontal-tb-rtl.html 1127488-align-top-right-ref.html
 HTTP(..) == 1127488-align-end-horizontal-tb-rtl.html 1127488-align-top-left-ref.html
--- a/layout/reftests/writing-mode/ua-style-sheet-input-number-1-ref.html
+++ b/layout/reftests/writing-mode/ua-style-sheet-input-number-1-ref.html
@@ -25,14 +25,15 @@ div { padding: 10px; }
 </div>
 
 <div class=rtl dir=rtl>
   <input type=number value=123><br><br>
   <input type=number value=456 class=a><br><br>
   <input type=number value=7890 class=b>
 </div>
 
-<!-- this will fail until bug 1123299 is fixed -->
+<!-- this will fail until bug 1123299 is fixed
 <div class=v-rl>
   <input type=number value=123><br><br>
   <input type=number value=456 class=a><br><br>
   <input type=number value=7890 class=b>
 </div>
+-->
--- a/layout/reftests/writing-mode/ua-style-sheet-input-number-1.html
+++ b/layout/reftests/writing-mode/ua-style-sheet-input-number-1.html
@@ -15,14 +15,15 @@ div { padding: 10px; }
 </div>
 
 <div class=rtl dir=rtl>
   <input type=number value=123><br><br>
   <input type=number value=456 class=a><br><br>
   <input type=number value=7890 class=b>
 </div>
 
-<!-- this will fail until bug 1123299 is fixed -->
+<!-- this will fail until bug 1123299 is fixed
 <div class=v-rl>
   <input type=number value=123><br><br>
   <input type=number value=456 class=a><br><br>
   <input type=number value=7890 class=b>
 </div>
+-->