Bug 801345 - Give MessageReplyDeserializer a virtual dtor since we delete the base class pointer; r=cjones
authorEhsan Akhgari <ehsan@mozilla.com>
Sun, 14 Oct 2012 11:11:04 -0400
changeset 110216 e3239845f9d2222b5e385247ba19eefecc5ad2ae
parent 110215 d178bdc3a5572677547f829702eb30e6cf42e183
child 110217 43f597d00b4bc7e8ff0083ea5f222bf8d8e5858e
push id16400
push usereakhgari@mozilla.com
push dateSun, 14 Oct 2012 15:12:08 +0000
treeherdermozilla-inbound@43f597d00b4b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones
bugs801345
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 801345 - Give MessageReplyDeserializer a virtual dtor since we delete the base class pointer; r=cjones
ipc/chromium/src/chrome/common/ipc_sync_message.h
--- a/ipc/chromium/src/chrome/common/ipc_sync_message.h
+++ b/ipc/chromium/src/chrome/common/ipc_sync_message.h
@@ -80,16 +80,17 @@ class SyncMessage : public Message {
 
   static uint32_t next_id_;  // for generation of unique ids
 };
 
 // Used to deserialize parameters from a reply to a synchronous message
 class MessageReplyDeserializer {
  public:
   bool SerializeOutputParameters(const Message& msg);
+  virtual ~MessageReplyDeserializer() {}
  private:
   // Derived classes need to implement this, using the given iterator (which
   // is skipped past the header for synchronous messages).
   virtual bool SerializeOutputParameters(const Message& msg, void* iter) = 0;
 };
 
 }  // namespace IPC