Backed out changeset b7597732606e (bug 1501623)for failing at browser_autocomplete_edit_completed.js on a CLOSED TREE.
authorGurzau Raul <rgurzau@mozilla.com>
Sat, 02 Feb 2019 02:43:33 +0200
changeset 456527 e2780a098404114db5aea796c87e577ce2c54f05
parent 456526 43d250c96e71928eb14dbd6dde03595959b36f89
child 456528 e53f607940cb5e1db1bb7eeb3c5c0bc6f4b0d608
push id111656
push userdvarga@mozilla.com
push dateSat, 02 Feb 2019 09:51:54 +0000
treeherdermozilla-inbound@d8cebb3b46cf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1501623
milestone67.0a1
backs outb7597732606e96cd3337c316b5771ae09e9b8ab9
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b7597732606e (bug 1501623)for failing at browser_autocomplete_edit_completed.js on a CLOSED TREE.
browser/components/urlbar/UrlbarInput.jsm
--- a/browser/components/urlbar/UrlbarInput.jsm
+++ b/browser/components/urlbar/UrlbarInput.jsm
@@ -362,16 +362,17 @@ class UrlbarInput {
 
   /**
    * Called by the view when moving through results with the keyboard.
    *
    * @param {UrlbarResult} result The result that was selected.
    */
   setValueFromResult(result) {
     let val;
+
     switch (result.type) {
       case UrlbarUtils.RESULT_TYPE.SEARCH:
         val = result.payload.suggestion || result.payload.query;
         break;
       case UrlbarUtils.RESULT_TYPE.OMNIBOX:
         val = result.payload.content;
         break;
       default: {
@@ -383,23 +384,16 @@ class UrlbarInput {
         if (uri) {
           val = this.window.losslessDecodeURI(uri);
         }
         break;
       }
     }
     this.value = val;
 
-    // Dispatch the input event to update userTypedValue. See bug 287996.
-    let event = this.document.createEvent("UIEvents");
-    event.initUIEvent("input", true, false, this.window, 0);
-    this.inputField.dispatchEvent(event);
-
-    // Both the value setter and the input event handler clobber the actiontype
-    // attribute, so update this last.
     switch (result.type) {
       case UrlbarUtils.RESULT_TYPE.TAB_SWITCH:
         this.setAttribute("actiontype", "switchtab");
         break;
       case UrlbarUtils.RESULT_TYPE.OMNIBOX:
         this.setAttribute("actiontype", "extension");
         break;
     }