Bug 1437643 [wpt PR 9486] - Async Cookies: Fix globals in idlharness test, a=testonly
authorJoshua Bell <jsbell@chromium.org>
Mon, 26 Mar 2018 11:30:30 +0000
changeset 410897 e13055d8b5d76dfce4a3e9a5700e4cd7d7eab3d0
parent 410896 641bc88d9adb7988ae43684737928eda9b714d53
child 410898 d82533cefcd14f82fbd5de0a483def26001cb5c4
push id101593
push userjames@hoppipolla.co.uk
push dateSat, 31 Mar 2018 22:09:06 +0000
treeherdermozilla-inbound@feb3750f2fac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1437643, 729800, 914568, 536189
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1437643 [wpt PR 9486] - Async Cookies: Fix globals in idlharness test, a=testonly Automatic update from web-platform-testsAsync Cookies: Fix globals in idlharness test Globals (Window, ServiceWorkerGlobalScope, etc) get special bindings treatment for methods/properties and IDL tests for features need to declare these types correctly for correct results. Fix the SW test for the new cookie store API by marking the global with the [Global] extended attribute; this reveals that our implementation passes all the bindings test cases. Bug: 729800 Change-Id: I87747ed2af8d932342e24c9400524d88c9df73a7 Reviewed-on: https://chromium-review.googlesource.com/914568 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#536189} wpt-commits: b0e401ab8394d8117db2bce6095dedf0150c66d6 wpt-pr: 9486 wpt-commits: b0e401ab8394d8117db2bce6095dedf0150c66d6 wpt-pr: 9486
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/cookie-store/idlharness.tentative.html
testing/web-platform/tests/cookie-store/idlharness_serviceworker.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -416593,21 +416593,21 @@
    "42c03466979c5e6d94803d5e69b6c07a595e9728",
    "testharness"
   ],
   "cookie-store/http_cookie_and_set_cookie_headers.tentative.https.html": [
    "11c763dd1b7b3a1bff14b9f65538fb33ca97b81b",
    "testharness"
   ],
   "cookie-store/idlharness.tentative.html": [
-   "ebe74eee2decbe18fd0dc80035b447d852abaaef",
+   "80fd85490924312c3684cc0a7bf1b7a8c39a176e",
    "testharness"
   ],
   "cookie-store/idlharness_serviceworker.js": [
-   "abc14989e63b8eaeee877a41088bd34139545f02",
+   "34790d2326bc4c23b1a3dcf0435d987654955170",
    "support"
   ],
   "cookie-store/idlharness_serviceworker.tentative.https.html": [
    "0c8a1302ab1839cab71c87db2bda1ca6abcb6a23",
    "testharness"
   ],
   "cookie-store/meta_http_equiv_set_cookie.tentative.html": [
    "6b7dc5aaa1f3c765c45886017163b70520e5f367",
--- a/testing/web-platform/tests/cookie-store/idlharness.tentative.html
+++ b/testing/web-platform/tests/cookie-store/idlharness.tentative.html
@@ -16,17 +16,19 @@ promise_test(async t => {
 
   const idl_array = new IdlArray();
 
   // Dependencies of HTML
   idl_array.add_untested_idls('interface Document {};');
   idl_array.add_untested_idls('interface LinkStyle {};');
   idl_array.add_untested_idls(html);
 
-  idl_array.add_untested_idls('[Exposed=ServiceWorker] interface ServiceWorkerGlobalScope {};');
+  idl_array.add_untested_idls(
+    `[Global=ServiceWorker, Exposed=ServiceWorker]
+     interface ServiceWorkerGlobalScope {};`);
 
   idl_array.add_idls(cookie_store);
 
   idl_array.add_objects({
     CookieStore: [self.cookieStore],
   });
   idl_array.test();
 }, 'Interface test');
--- a/testing/web-platform/tests/cookie-store/idlharness_serviceworker.js
+++ b/testing/web-platform/tests/cookie-store/idlharness_serviceworker.js
@@ -8,18 +8,22 @@ importScripts('/resources/testharness.js
 
 promise_test(async t => {
   const urls = ['cookie-store.idl'];
   const [cookie_store] = await Promise.all(
     urls.map(url => fetch(url).then(response => response.text())));
 
   const idl_array = new IdlArray();
 
-  idl_array.add_untested_idls('[Exposed=ServiceWorker] interface ServiceWorkerGlobalScope {};');
-  idl_array.add_untested_idls('[Exposed=Window] interface Window {};');
+  idl_array.add_untested_idls(
+    `[Global=ServiceWorker, Exposed=ServiceWorker]
+     interface ServiceWorkerGlobalScope {};`);
+  idl_array.add_untested_idls(
+    `[Global=Window, Exposed=Window]
+     interface Window {};`);
 
   idl_array.add_idls(cookie_store);
 
   idl_array.add_objects({
     CookieStore: [self.cookieStore],
   });
   idl_array.test();
 }, 'Interface test');