Bug 1544612 - remove tpaint. r=rwood
authorJoel Maher <jmaher@mozilla.com>
Wed, 17 Apr 2019 10:43:29 +0000
changeset 469811 e0f7fc19d5cb
parent 469810 8d0276626d4f
child 469812 ee8e96e5d015
push id112825
push usercbrindusan@mozilla.com
push dateWed, 17 Apr 2019 15:58:37 +0000
treeherdermozilla-inbound@7bd43da7830c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrwood
bugs1544612
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1544612 - remove tpaint. r=rwood remove outdated talos test, tpaint Differential Revision: https://phabricator.services.mozilla.com/D27689
testing/talos/talos.json
testing/talos/talos/test.py
testing/talos/talos/tests/tpaint/tpaint.html
testing/talos/talos/tests/tpaint/tpaint.manifest
testing/talos/talos/unittests/test_config.py
--- a/testing/talos/talos.json
+++ b/testing/talos/talos.json
@@ -8,17 +8,17 @@
         },
         "dromaeojs": {
             "tests": ["dromaeo_css", "kraken"]
         },
         "flex": {
             "tests": ["tart_flex", "ts_paint_flex"]
         },
         "other": {
-            "tests": ["a11yr", "ts_paint", "tpaint", "twinopen", "sessionrestore", "sessionrestore_no_auto_restore", "tabpaint", "cpstartup", "startup_about_home_paint"]
+            "tests": ["a11yr", "ts_paint", "twinopen", "sessionrestore", "sessionrestore_no_auto_restore", "tabpaint", "cpstartup", "startup_about_home_paint"]
         },
         "sessionrestore-many-windows": {
             "tests": ["sessionrestore_many_windows"]
         },
         "g1": {
             "tests": ["tp5o_scroll", "glterrain"],
             "pagesets_name": "tp5n.zip"
         },
--- a/testing/talos/talos/test.py
+++ b/testing/talos/talos/test.py
@@ -266,36 +266,16 @@ class QuantumPageloadTest(PageloaderTest
     gecko_profile_entries = 2000000
     filters = filter.ignore_first.prepare(5) + filter.median.prepare()
     unit = 'ms'
     lower_is_better = True
     fnbpaint = True
 
 
 @register_test()
-class tpaint(PageloaderTest):
-    """
-    Tests the amount of time it takes the open a new window. This test does
-    not include startup time. Multiple test windows are opened in succession,
-    results reported are the average amount of time required to create and
-    display a window in the running instance of the browser.
-    (Measures ctrl-n performance.)
-    """
-    tpmanifest = '${talos}/tests/tpaint/tpaint.manifest'
-    tppagecycles = 20
-    timeout = 300
-    gecko_profile_interval = 1
-    gecko_profile_entries = 2000000
-    tpmozafterpaint = True
-    filters = filter.ignore_first.prepare(5) + filter.median.prepare()
-    unit = 'ms'
-    preferences = {'security.data_uri.block_toplevel_data_uri_navigations': False}
-
-
-@register_test()
 class twinopen(PageloaderTest):
     """
     Tests the amount of time it takes an open browser to open a new browser
     window and paint the browser chrome. This test does not include startup
     time. Multiple test windows are opened in succession.
     (Measures ctrl-n performance.)
     """
     extensions = ['${talos}/pageloader', '${talos}/tests/twinopen']
deleted file mode 100644
--- a/testing/talos/talos/tests/tpaint/tpaint.html
+++ /dev/null
@@ -1,87 +0,0 @@
-<html>
-<meta charset='utf-8'>
-<script language="JavaScript" type="text/javascript" src="../../scripts/MozillaFileLogger.js"></script>
-<script language="JavaScript" src="resource://talos-powers/TalosContentProfiler.js"></script>
-<script language="JavaScript" type="text/javascript" src="resource://talos-powers/TalosPowersContent.js"></script>
-<script>
-var OPENER_DELAY = 1000; // ms delay between tests
-var kid, kidStartTime, kidEndTime, openTime;
-var auto = document.location.search.split("=")[1]; // ?auto=1
-
-/*
- * tpaint -- measures the amount of time between opening a new window
- *           its contents being painted.
- *
- * XXX When run manually, outside of automation, need to:
- *     1) allow popups
- *     2) set dom.send_after_paint_to_content = true
- *     3) set browser.link.open_newwindow = 2 (else it opens in a tab)
- */
-
-async function startTest() {
-  await TalosContentProfiler.resume("tpaint", true);
-  scheduleNextWindow();
-}
-
-function scheduleNextWindow() {
-  TalosPowersContent.forceCCAndGC();
-  window.setTimeout(openWindow, OPENER_DELAY);
-}
-
-function calcMedian( numbers ) {
-  // Avoid changing the original array.
-  var sortedNumbers = Array.from(numbers);
-  sortedNumbers.sort( function(a, b) { return a - b; } );
-  var n = Math.floor( sortedNumbers.length / 2 );
-  if (sortedNumbers.length % 2) {
-    return sortedNumbers[n];
-  }
-  return ( sortedNumbers[n - 1] + sortedNumbers[n] ) / 2;
-}
-
-async function reportTimes() {
-  if (window.tpRecordTime)
-    window.tpRecordTime(openTime);
-
-  if (auto) {
-    dumpLog("openingTime=" + openTime + "\n");
-  }
-}
-
-window.addEventListener("message", childIsOpen);
-async function childIsOpen() {
-  kidEndTime = window.performance.now();
-  openTime = kidEndTime - kidStartTime;
-  await TalosContentProfiler.pause("tpaint", true);
-
-  window.removeEventListener("message", childIsOpen);
-  window.setTimeout(reportTimes, 0);
-}
-
-/* eslint-disable no-useless-concat */
-var kidHTML = "<html><meta charset='utf-8'><script>" +
-              "var e = 'MozAfterPaint';" +
-              "function done() {" +
-              "  window.removeEventListener(e, done, true);" +
-              "  window.opener.postMessage({msg: 'childIsOpen'}, '*');" +
-              "  window.close();" +
-              "}" +
-              "window.addEventListener(e, done, true);" +
-              "</" + "script>TPAINT</html>";
-/* eslint-enable no-useless-concat */
-var kidURI = "data:text/html," + encodeURI(kidHTML);
-
-async function openWindow() {
-  await TalosContentProfiler.resume("tpaint");
-  kidStartTime = window.performance.now();
-  kid = window.open(kidURI);
-}
-
-if (auto)
-  startTest();
-
-</script>
-<h2>tpaint runner</h2>
-<button onclick="startTest()">Start</button>
-</html>
-
deleted file mode 100644
--- a/testing/talos/talos/tests/tpaint/tpaint.manifest
+++ /dev/null
@@ -1,1 +0,0 @@
-% http://localhost/tests/tpaint/tpaint.html?auto=1
\ No newline at end of file
--- a/testing/talos/talos/unittests/test_config.py
+++ b/testing/talos/talos/unittests/test_config.py
@@ -196,17 +196,16 @@ class Test_get_config(object):
         cls.argv_ts_paint_webext = '--activeTests ts_paint_webext -e /some/random/path'.split()
         cls.argv_ts_paint_heavy = '--activeTests ts_paint_heavy -e /some/random/path'.split()
         cls.argv_sessionrestore = '--activeTests sessionrestore -e /some/random/path'.split()
         cls.argv_sessionrestore_no_auto_restore = \
             '--activeTests sessionrestore_no_auto_restore -e /some/random/path'.split()
         cls.argv_sessionrestore_many_windows = \
             '--activeTests sessionrestore_many_windows -e /some/random/path'.split()
         cls.argv_tresize = '--activeTests tresize -e /some/random/path'.split()
-        cls.argv_tpaint = '--activeTests tpaint -e /some/random/path'.split()
         cls.argv_cpstartup = '--activeTests cpstartup -e /some/random/path'.split()
         cls.argv_tabpaint = '--activeTests tabpaint -e /some/random/path'.split()
         cls.argv_tabswitch = '--activeTests tabswitch -e /some/random/path'.split()
         cls.argv_tart = '--activeTests tart -e /some/random/path'.split()
         cls.argv_damp = '--activeTests damp -e /some/random/path'.split()
         cls.argv_glterrain = '--activeTests glterrain -e /some/random/path'.split()
         cls.argv_glvideo = '--activeTests glvideo -e /some/random/path'.split()
         cls.argv_tp5n = '--activeTests tp5n -e /some/random/path'.split()
@@ -390,32 +389,16 @@ class Test_get_config(object):
         assert test_config['url'] != 'startup_test/tresize/addon/content/tresize-test.html'
         assert test_config['timeout'] == 150
         assert test_config['gecko_profile_interval'] == 2
         assert test_config['gecko_profile_entries'] == 1000000
         assert test_config['tpmozafterpaint'] is True
         assert test_config['filters'] is not None
         # assert test_config['unit'] == 'ms'
 
-    def test_tpaint_has_expected_attributes(self):
-        config = get_config(self.argv_tpaint)
-        test_config = config['tests'][0]
-
-        assert test_config['name'] == 'tpaint'
-        assert test_config['tpcycles'] == 1
-        assert test_config['tppagecycles'] == 20
-        assert test_config['timeout'] == 300
-        assert test_config['gecko_profile_interval'] == 1
-        assert test_config['gecko_profile_entries'] == 2000000
-        assert test_config['tpmozafterpaint'] is True
-        assert test_config['filters'] is not None
-        assert test_config['unit'] == 'ms'
-        assert test_config['preferences'] == {
-            'security.data_uri.block_toplevel_data_uri_navigations': False}
-
     def test_cpstartup_has_expected_attributes(self):
         config = get_config(self.argv_cpstartup)
         test_config = config['tests'][0]
 
         assert test_config['name'] == 'cpstartup'
         assert test_config['tpcycles'] == 1
         assert test_config['tpmanifest'] != '${talos}/tests/cpstartup/cpstartup.manifest'
         assert test_config['tppagecycles'] == 20