Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r=dustin
authorTom Prince <mozilla@hocat.ca>
Thu, 05 Apr 2018 15:31:33 -0600
changeset 412177 e0cb209d9f3f307826944eae2d552b5a5bbe83e4
parent 412176 e8f1530940a5c38f01955f8fcb886496ae6ca1ae
child 412178 0c1a171c57ef9321e7083f1fa8ac0f053785c205
push id101851
push usermozilla@hocat.ca
push dateFri, 06 Apr 2018 22:32:40 +0000
treeherdermozilla-inbound@918004b0cc5d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
bugs1451962
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r=dustin Make it clear that the function filters out nightly tasks. Differential Revision: https://phabricator.services.mozilla.com/D861
taskcluster/taskgraph/target_tasks.py
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -19,17 +19,17 @@ def _target_task(name):
     return wrap
 
 
 def get_method(method):
     """Get a target_task_method to pass to a TaskGraphGenerator."""
     return _target_task_methods[method]
 
 
-def filter_on_nightly(task, parameters):
+def filter_out_nightly(task, parameters):
     return not task.attributes.get('nightly') or parameters.get('include_nightly')
 
 
 def filter_for_project(task, parameters):
     """Filter tasks by project.  Optionally enable nightlies."""
     run_on_projects = set(task.attributes.get('run_on_projects', []))
     return match_run_on_projects(parameters['project'], run_on_projects)
 
@@ -83,17 +83,17 @@ def filter_beta_release_tasks(task, para
         return False
 
     return True
 
 
 def standard_filter(task, parameters):
     return all(
         filter_func(task, parameters) for filter_func in
-        (filter_on_nightly, filter_for_project, filter_upload_symbols)
+        (filter_out_nightly, filter_for_project, filter_upload_symbols)
     )
 
 
 def _try_task_config(full_task_graph, parameters, graph_config):
     requested_tasks = parameters['try_task_config']['tasks']
     return list(set(requested_tasks) & full_task_graph.graph.nodes)