Bug 1248360 - Set eslint version to 1.10.3 when setting it up via mach
authorPatrick Brosset <pbrosset@mozilla.com>
Tue, 16 Feb 2016 10:01:11 +0100
changeset 284532 e0197b0616f937b19d5ba740cb221cde454e03fa
parent 284531 66831b3d59bd2d3de39b2845cdf5a555c184f2e0
child 284533 bf152107a11d801dec09449aa24140bd4d9f518e
push id71993
push usercbook@mozilla.com
push dateWed, 17 Feb 2016 11:16:29 +0000
treeherdermozilla-inbound@60f020c84b23 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1248360
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1248360 - Set eslint version to 1.10.3 when setting it up via mach MozReview-Commit-ID: LmKsvGzj3fo
python/mach_commands.py
--- a/python/mach_commands.py
+++ b/python/mach_commands.py
@@ -214,19 +214,21 @@ class MachCommands(MachCommandBase):
         eslint for optimal use on Mozilla projects.
         """
         sys.path.append(os.path.dirname(__file__))
 
         npmPath = self.getNodeOrNpmPath("npm")
         if not npmPath:
             return 1
 
-        # Install eslint.
+        # Install eslint 1.10.3.
+        # Note that that's the version currently compatible with the mozilla
+        # eslint plugin.
         success = self.callProcess("eslint",
-                                   [npmPath, "install", "eslint", "-g"])
+                                   [npmPath, "install", "eslint@1.10.3", "-g"])
         if not success:
             return 1
 
         # Install eslint-plugin-mozilla.
         success = self.callProcess("eslint-plugin-mozilla",
                                    [npmPath, "link"],
                                    "testing/eslint-plugin-mozilla")
         if not success: