Bug 1585011 [wpt PR 19402] - [wptrunner] Explicitly ignore certificate errors for Chrome, a=testonly
authorRobert Ma <robertma@chromium.org>
Thu, 03 Oct 2019 09:54:44 +0000
changeset 496519 de27713ec2e40e8662d14c798e85297a25291f55
parent 496518 d610eaca6dfcf9c8d4b8e38bb29ed31cedef9c6b
child 496520 1954038204acd69851c0be17d687399ded4c5c70
push id114144
push userwptsync@mozilla.com
push dateMon, 07 Oct 2019 10:18:06 +0000
treeherdermozilla-inbound@aa50a7580ed4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1585011, 19402
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1585011 [wpt PR 19402] - [wptrunner] Explicitly ignore certificate errors for Chrome, a=testonly Automatic update from web-platform-tests [wptrunner] Explicitly ignore certificate errors for Chrome ChromeDriver will no longer pass --ignore-certificate-error by default and users need to explicitly request the acceptInsecureCerts capability. https://crbug.com/chromedriver/3148 -- wpt-commits: 98fe3d29b673c33e468e5661709a4e3ca33189d1 wpt-pr: 19402
testing/web-platform/tests/tools/wpt/tests/test_wpt.py
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome.py
--- a/testing/web-platform/tests/tools/wpt/tests/test_wpt.py
+++ b/testing/web-platform/tests/tools/wpt/tests/test_wpt.py
@@ -341,17 +341,17 @@ def test_tests_affected(capsys, manifest
 @pytest.mark.skipif(sys.platform == "win32",
                     reason="https://github.com/web-platform-tests/wpt/issues/12934")
 def test_tests_affected_idlharness(capsys, manifest_dir):
     commit = "47cea8c38b88c0ddd3854e4edec0c5b6f2697e62"
     with pytest.raises(SystemExit) as excinfo:
         wpt.main(argv=["tests-affected", "--metadata", manifest_dir, "%s~..%s" % (commit, commit)])
     assert excinfo.value.code == 0
     out, err = capsys.readouterr()
-    assert "webrtc-stats/idlharness.window.js\nwebrtc/idlharness.https.window.js\n" == out
+    assert "webrtc-identity/idlharness.https.window.js\nwebrtc-stats/idlharness.window.js\nwebrtc/idlharness.https.window.js\n" == out
 
 
 @pytest.mark.slow  # this updates the manifest
 @pytest.mark.xfail(sys.platform == "win32",
                    reason="Tests currently don't work on Windows for path reasons")
 @pytest.mark.skipif(sys.platform == "win32",
                     reason="https://github.com/web-platform-tests/wpt/issues/12934")
 def test_tests_affected_null(capsys, manifest_dir):
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome.py
@@ -34,16 +34,17 @@ def executor_kwargs(test_type, server_co
                     **kwargs):
     executor_kwargs = base_executor_kwargs(test_type, server_config,
                                            cache_manager, run_info_data,
                                            **kwargs)
     executor_kwargs["close_after_done"] = True
     executor_kwargs["supports_eager_pageload"] = False
 
     capabilities = {
+        "acceptInsecureCerts": True,
         "goog:chromeOptions": {
             "prefs": {
                 "profile": {
                     "default_content_setting_values": {
                         "popups": 1
                     }
                 }
             },