Bug 1484190 - Unblock MSVC 2017 15.8. r=dmajor
☠☠ backed out by 2e949e5a9a62 ☠ ☠
authorMasatoshi Kimura <VYV03354@nifty.ne.jp>
Fri, 17 Aug 2018 20:41:49 +0900
changeset 432407 dca5444170e0a59c7a3a5321bece62d717fb6c1a
parent 432406 1ef81d07bc5b94f6ff37954c204da264ee16e6b6
child 432408 5811b189a158716f420b8071c0841fd65b2cc71c
push id106728
push userVYV03354@nifty.ne.jp
push dateMon, 20 Aug 2018 16:14:18 +0000
treeherdermozilla-inbound@dca5444170e0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1484190
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1484190 - Unblock MSVC 2017 15.8. r=dmajor
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -928,29 +928,29 @@ def compiler(language, host_or_target, c
             raise FatalCheckError(
                 'Only clang/llvm 3.6 or newer is supported.')
 
         if info.type == 'msvc':
             if info.version < '19.13.26128':
                 raise FatalCheckError(
                     'This version (%s) of the MSVC compiler is not '
                     'supported.\n'
-                    'You must install Visual C++ 2017 Update 6 in '
-                    'order to build.\n'
+                    'You must install Visual C++ 2017 Update 6 or '
+                    'Update 8 or later in order to build.\n'
                     'See https://developer.mozilla.org/en/'
                     'Windows_Build_Prerequisites' % info.version)
 
             # MSVC version 15.7 and the previews for 15.8, at least,
             # can't build Firefox.
-            if info.version >= '19.14.0':
+            if info.version >= '19.14.0' and info.version < '19.15.0':
                 raise FatalCheckError(
                     'This version (%s) of the MSVC compiler is not '
                     'supported due to compiler bugs.\n'
-                    'You must install Visual C++ 2017 Update 6 in '
-                    'order to build.\n'
+                    'You must install Visual C++ 2017 Update 6 or '
+                    'Update 8 or later in order to build.\n'
                     'See https://developer.mozilla.org/en/'
                     'Windows_Build_Prerequisites' % info.version)
 
         if info.flags:
             raise FatalCheckError(
                 'Unknown compiler or compiler not supported.')
 
         return namespace(