Bug 1416020 - Remove unused variables from client.mk; r=nalexander
authorGregory Szorc <gps@mozilla.com>
Thu, 09 Nov 2017 14:19:41 -0800
changeset 391160 db9cecd33c001423851c33bcc78ab43575ea4e83
parent 391159 512bc6565c8065cd0ff9a933f2705047e72bd7f7
child 391161 5f3ad5cd80602d9d2b9e912be92776b445a8332a
push id97202
push usernerli@mozilla.com
push dateFri, 10 Nov 2017 10:46:38 +0000
treeherdermozilla-inbound@915df99dbfe7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1416020
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1416020 - Remove unused variables from client.mk; r=nalexander The last use of PERL was removed recently. The last use of comma was removed by c8276e89a513 in 2008. The last use of SH was... never AFAICT. The variable was defined but unused in the initial import of client.mk from CVS in 1998. MozReview-Commit-ID: LFqcVRf36wf
client.mk
--- a/client.mk
+++ b/client.mk
@@ -11,18 +11,16 @@
 #
 # Options:
 #   MOZ_OBJDIR           - Destination object directory
 #   MOZ_MAKE_FLAGS       - Flags to pass to $(MAKE)
 #
 #######################################################################
 # Defines
 
-comma := ,
-
 ifdef MACH
 ifndef NO_BUILDSTATUS_MESSAGES
 define BUILDSTATUS
 @echo 'BUILDSTATUS $1'
 
 endef
 endif
 endif
@@ -37,18 +35,16 @@ endif
 ifndef TOPSRCDIR
 ifeq (,$(wildcard client.mk))
 TOPSRCDIR := $(patsubst %/,%,$(dir $(MAKEFILE_LIST)))
 else
 TOPSRCDIR := $(CWD)
 endif
 endif
 
-SH := /bin/sh
-PERL ?= perl
 PYTHON ?= $(shell which python2.7 > /dev/null 2>&1 && echo python2.7 || echo python)
 
 CONFIG_GUESS := $(shell $(TOPSRCDIR)/build/autoconf/config.guess)
 
 ####################################
 # Sanity checks
 
 # Windows checks.