Bug 1447460: Mark some obsolete `mach taskgraph cron` parameters as ignored; r=dustin
authorTom Prince <mozilla@hocat.ca>
Tue, 27 Mar 2018 10:30:02 -0700
changeset 410432 d87865851500487d86a67978c7ab498640a1a4d1
parent 410431 d3a59e1b1be58fc4f824dc62ded7ba7d57f89157
child 410433 c4730aaaf5575dbca450a9819c13f30dedc7a98e
push id101502
push usermozilla@hocat.ca
push dateWed, 28 Mar 2018 20:03:52 +0000
treeherdermozilla-inbound@c4730aaaf557 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
bugs1447460
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1447460: Mark some obsolete `mach taskgraph cron` parameters as ignored; r=dustin Differential Revision: https://phabricator.services.mozilla.com/D814
taskcluster/mach_commands.py
taskcluster/taskgraph/cron/__init__.py
--- a/taskcluster/mach_commands.py
+++ b/taskcluster/mach_commands.py
@@ -169,24 +169,24 @@ class MachCommands(MachCommandBase):
             return taskgraph.decision.taskgraph_decision(options)
         except Exception:
             traceback.print_exc()
             sys.exit(1)
 
     @SubCommand('taskgraph', 'cron',
                 description="Run the cron task")
     @CommandArgument('--base-repository',
-                     required=True,
-                     help='URL for "base" repository to clone')
+                     required=False,
+                     help='(ignored)')
     @CommandArgument('--head-repository',
                      required=True,
                      help='URL for "head" repository to fetch')
     @CommandArgument('--head-ref',
-                     required=True,
-                     help='Reference to fetch in head-repository (usually "default")')
+                     required=False,
+                     help='(ignored)')
     @CommandArgument('--project',
                      required=True,
                      help='Project to use for creating tasks. Example: --project=mozilla-central')
     @CommandArgument('--level',
                      required=True,
                      help='SCM level of this repository')
     @CommandArgument('--force-run',
                      required=False,
--- a/taskcluster/taskgraph/cron/__init__.py
+++ b/taskcluster/taskgraph/cron/__init__.py
@@ -122,23 +122,18 @@ def calculate_time(options):
 
 
 def taskgraph_cron(options):
     params = {
         # name of this cron job (set per job below)
         'job_name': '..',
 
         # repositories
-        'base_repository': options['base_repository'],
         'head_repository': options['head_repository'],
 
-        # the symbolic ref this should run against (which happens to be what
-        # run-task checked out for us)
-        'head_ref': options['head_ref'],
-
         # *calculated* head_rev; this is based on the current meaning of this
         # reference in the working copy
         'head_rev': calculate_head_rev(options),
 
         # the project (short name for the repository) and its SCM level
         'project': options['project'],
         'level': options['level'],