Bug 1276093 - Warn when we fail to hit the GPU-copy fast-path. - r=jrmuizel
authorJeff Gilbert <jgilbert@mozilla.com>
Tue, 31 May 2016 19:18:31 -0700
changeset 299846 d85f0530eb80a5644a440638a87f981de890aea5
parent 299845 c2fc488c389f0cfc6b6dc60a16b34e7f2036e87d
child 299847 5d9b7a5387ed5342e37224ca07a083127458b0e2
push id77712
push userjgilbert@mozilla.com
push dateWed, 01 Jun 2016 02:37:22 +0000
treeherdermozilla-inbound@d85f0530eb80 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1276093
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1276093 - Warn when we fail to hit the GPU-copy fast-path. - r=jrmuizel
dom/canvas/TexUnpackBlob.cpp
--- a/dom/canvas/TexUnpackBlob.cpp
+++ b/dom/canvas/TexUnpackBlob.cpp
@@ -307,16 +307,20 @@ TexUnpackImage::TexOrSubImage(bool isSub
                                                       dstOrigin))
         {
             break;
         }
 
         return; // Blitting was successful, so we're done!
     } while (false);
 
+    webgl->GenerateWarning("%s: Failed to hit GPU-copy fast-path. Falling back to CPU"
+                           " upload.",
+                           funcName);
+
     RefPtr<SourceSurface> surface = mImage->GetAsSourceSurface();
     if (!surface) {
         *out_glError = LOCAL_GL_OUT_OF_MEMORY;
         return;
     }
 
     TexUnpackSurface surfBlob(surface, mIsAlphaPremult);