Bug 1551084 - Part 2. Make QCMS transform files use C++. r=miko
☠☠ backed out by 1e50992f4133 ☠ ☠
authorAndrew Osmond <aosmond@mozilla.com>
Thu, 09 May 2019 17:13:45 -0400
changeset 475665 d73949bd98e99a892a282a85b68aeb44cd972ffc
parent 475664 cd1bb23b475a065640e6fa0783634636288b7f6b
child 475666 99874bf8941910abd3c10f0ba5a762e7f1dc60f5
push id113222
push useraosmond@gmail.com
push dateMon, 27 May 2019 15:17:15 +0000
treeherdermozilla-inbound@af04f8907fab [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmiko
bugs1551084
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551084 - Part 2. Make QCMS transform files use C++. r=miko Differential Revision: https://phabricator.services.mozilla.com/D30819
CLOBBER
gfx/qcms/moz.build
gfx/qcms/transform-altivec.c
gfx/qcms/transform-altivec.cpp
gfx/qcms/transform-sse1.c
gfx/qcms/transform-sse1.cpp
gfx/qcms/transform-sse2.c
gfx/qcms/transform-sse2.cpp
gfx/qcms/transform.c
gfx/qcms/transform.cpp
--- a/CLOBBER
+++ b/CLOBBER
@@ -17,9 +17,9 @@
 #
 # Modifying this file will now automatically clobber the buildbot machines \o/
 #
 
 # Are you updating CLOBBER because you think it's needed for your WebIDL
 # changes to stick? As of bug 928195, this shouldn't be necessary! Please
 # don't change CLOBBER for WebIDL changes any more.
 
-Merge day clobber
\ No newline at end of file
+Bug 1551084 - Part 2. Make QCMS transform files use C++. r=miko
--- a/gfx/qcms/moz.build
+++ b/gfx/qcms/moz.build
@@ -8,17 +8,17 @@ EXPORTS += [
     'qcms.h',
     'qcmstypes.h',
 ]
 
 SOURCES += [
     'chain.c',
     'iccread.c',
     'matrix.c',
-    'transform.c',
+    'transform.cpp',
     'transform_util.c',
 ]
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CFLAGS += ['-Wno-missing-field-initializers']
 
@@ -31,25 +31,25 @@ if CONFIG['INTEL_ARCHITECTURE']:
         if CONFIG['OS_ARCH'] != 'WINNT' or CONFIG['CPU_ARCH'] != 'x86_64':
             use_sse1 = True
     else:
         use_sse1 = True
 elif CONFIG['HAVE_ALTIVEC']:
     use_altivec = True
 
 if use_sse1:
-    SOURCES += ['transform-sse1.c']
-    SOURCES['transform-sse1.c'].flags += CONFIG['SSE_FLAGS']
+    SOURCES += ['transform-sse1.cpp']
+    SOURCES['transform-sse1.cpp'].flags += CONFIG['SSE_FLAGS']
 
 if use_sse2:
     SOURCES += ['transform-sse2.cpp']
     SOURCES['transform-sse2.cpp'].flags += CONFIG['SSE2_FLAGS']
 
 if use_altivec:
-    SOURCES += ['transform-altivec.c']
-    SOURCES['transform-altivec.c'].flags += ['-maltivec']
+    SOURCES += ['transform-altivec.cpp']
+    SOURCES['transform-altivec.cpp'].flags += ['-maltivec']
 
 include('/tools/fuzzing/libfuzzer-config.mozbuild')
 
 if CONFIG['FUZZING_INTERFACES']:
     TEST_DIRS += [
         'fuzztest'
     ]
rename from gfx/qcms/transform-altivec.c
rename to gfx/qcms/transform-altivec.cpp
rename from gfx/qcms/transform-sse1.c
rename to gfx/qcms/transform-sse1.cpp
rename from gfx/qcms/transform-sse2.c
rename to gfx/qcms/transform-sse2.cpp
rename from gfx/qcms/transform.c
rename to gfx/qcms/transform.cpp