Bug 1472684: Hide info bar and guides from highlighter. r=gl
authorDaisuke Akatsuka <dakatsuka@mozilla.com>
Wed, 04 Jul 2018 10:50:12 +0900
changeset 424975 d6b45def3335f3ad5eeed9c856bdd28d17d3b33c
parent 424974 6a228e47a3bda33d0e8c3a3d45a633960c6fd9bf
child 424976 3d7f2fdc5bf7ca7521013b28e0d8be0785d2b58a
push id104946
push userrgurzau@mozilla.com
push dateWed, 04 Jul 2018 10:03:16 +0000
treeherdermozilla-inbound@796893f4d2f5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1472684
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472684: Hide info bar and guides from highlighter. r=gl MozReview-Commit-ID: AAchCYg0d61
devtools/client/inspector/animation/animation.js
devtools/client/inspector/animation/components/AnimationTarget.js
--- a/devtools/client/inspector/animation/animation.js
+++ b/devtools/client/inspector/animation/animation.js
@@ -512,17 +512,18 @@ class AnimationInspector {
    * If no node is provided, hide the box model highlighter.
    *
    * @param {NodeFront} nodeFront
    */
   async setHighlightedNode(nodeFront) {
     await this.inspector.highlighters.hideBoxModelHighlighter();
 
     if (nodeFront) {
-      await this.inspector.highlighters.showBoxModelHighlighter(nodeFront);
+      await this.inspector.highlighters.showBoxModelHighlighter(
+        nodeFront, { hideInfoBar: true, hideGuides: true });
     }
 
     this.inspector.store.dispatch(updateHighlightedNode(nodeFront));
   }
 
   /**
    * Returns simulatable animation by given parameters.
    * The returned animation is implementing Animation interface of Web Animation API.
--- a/devtools/client/inspector/animation/components/AnimationTarget.js
+++ b/devtools/client/inspector/animation/components/AnimationTarget.js
@@ -83,17 +83,18 @@ class AnimationTarget extends Component 
       await this.updateNodeFront(this.props.animation);
     }
   }
 
   async highlight() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
-      this.props.onShowBoxModelHighlighterForNode(this.state.nodeFront);
+      this.props.onShowBoxModelHighlighterForNode(
+        this.state.nodeFront, { hideInfoBar: true, hideGuides: true });
     }
   }
 
   async select() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
       this.props.setSelectedNode(this.state.nodeFront);