Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow
☠☠ backed out by 1b8819d514f8 ☠ ☠
authorPaul Bone <pbone@mozilla.com>
Thu, 14 Nov 2019 00:12:58 +0000
changeset 501861 d4c8a1b56b1ad44c9222fb78a470a5f4bc3b6423
parent 501860 b2d168294899bb4700cb3bd929c0bde85879fcea
child 501862 c4ff245706aba8e0dcbcabfadaf4cb752500b9c6
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1593545
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52804
netwerk/protocol/http/nsHttpChannel.cpp
--- a/netwerk/protocol/http/nsHttpChannel.cpp
+++ b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -2588,16 +2588,25 @@ nsresult nsHttpChannel::ContinueProcessR
   return ContinueProcessResponse2(rv);
 }
 
 void nsHttpChannel::AssertNotDocumentChannel() {
   if (!mLoadInfo || !IsDocument()) {
     return;
   }
 
+#ifndef DEBUG
+  if (!StaticPrefs::fission_autostart()) {
+    // This assertion is firing in the wild (Bug 1593545) and its not clear
+    // why. Disable the assertion in non-fission non-debug configurations to
+    // avoid crashing user's browsers until we're done dogfooding fission.
+    return;
+  }
+#endif
+
   nsCOMPtr<nsIParentChannel> parentChannel;
   NS_QueryNotificationCallbacks(this, parentChannel);
   RefPtr<DocumentChannelParent> documentChannelParent =
       do_QueryObject(parentChannel);
   if (documentChannelParent) {
     // The load is using document channel.
     return;
   }