Bug 1533890: Fix template mismatch in MacroAssembler-none r=jandem
authorIain Ireland <iireland@mozilla.com>
Wed, 20 Mar 2019 15:35:46 +0000
changeset 465228 d43f42ce6cf07fd76664767fafd1c55ee3e152bd
parent 465227 aa92f46d4de3078724ecd334da23e0dd9312a8bd
child 465229 1ac6a585937779eb00a89289822286600c3e8d51
push id112496
push usershindli@mozilla.com
push dateThu, 21 Mar 2019 04:37:39 +0000
treeherdermozilla-inbound@29476d3ca61d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1533890
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533890: Fix template mismatch in MacroAssembler-none r=jandem With this change, --disable-ion builds successfully. Differential Revision: https://phabricator.services.mozilla.com/D24202
js/src/jit/none/MacroAssembler-none.h
--- a/js/src/jit/none/MacroAssembler-none.h
+++ b/js/src/jit/none/MacroAssembler-none.h
@@ -291,17 +291,17 @@ class MacroAssemblerNone : public Assemb
   template <typename T, typename S>
   void pushValue(T, S) {
     MOZ_CRASH();
   }
   void popValue(ValueOperand) { MOZ_CRASH(); }
   void tagValue(JSValueType, Register, ValueOperand) { MOZ_CRASH(); }
   void retn(Imm32 n) { MOZ_CRASH(); }
   template <typename T>
-  void push(T) {
+  void push(const T&) {
     MOZ_CRASH();
   }
   template <typename T>
   void Push(T) {
     MOZ_CRASH();
   }
   template <typename T>
   void pop(T) {
@@ -335,17 +335,17 @@ class MacroAssemblerNone : public Assemb
   void mov(T, Register) {
     MOZ_CRASH();
   }
   template <typename T>
   void movePtr(T, Register) {
     MOZ_CRASH();
   }
   template <typename T>
-  void move32(T, Register) {
+  void move32(const T&, Register) {
     MOZ_CRASH();
   }
   template <typename T, typename S>
   void movq(T, S) {
     MOZ_CRASH();
   }
   template <typename T, typename S>
   void moveFloat32(T, S) {