Bug 869657: rename IsEventName to IsEventAttributeName in SVGAltGlyphElement and SVGTSpanElement. r=dholbert
authorJulien Levesy <jlevesy@gmail.com>
Thu, 09 May 2013 19:11:54 +0200
changeset 131441 d43e27c6362eb1242a1eddcaf05549e7b3ea0282
parent 131440 6312fc1ea87a4e78723a51cfefd50caaeb321119
child 131442 2834210d62bf428ea1d9a88a2c25b07b29f88419
push id27859
push userdholbert@mozilla.com
push dateFri, 10 May 2013 00:24:24 +0000
treeherdermozilla-inbound@d43e27c6362e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs869657
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 869657: rename IsEventName to IsEventAttributeName in SVGAltGlyphElement and SVGTSpanElement. r=dholbert
content/svg/content/src/SVGAltGlyphElement.cpp
content/svg/content/src/SVGAltGlyphElement.h
content/svg/content/src/SVGTSpanElement.cpp
content/svg/content/src/SVGTSpanElement.h
--- a/content/svg/content/src/SVGAltGlyphElement.cpp
+++ b/content/svg/content/src/SVGAltGlyphElement.cpp
@@ -80,25 +80,25 @@ SVGAltGlyphElement::IsAttributeMapped(co
     sGraphicsMap,
     sTextContentElementsMap
   };
 
   return FindAttributeDependence(name, map) ||
     SVGAltGlyphElementBase::IsAttributeMapped(name);
 }
 
-//----------------------------------------------------------------------
-// nsSVGElement overrides
-
 bool
-SVGAltGlyphElement::IsEventName(nsIAtom* aName)
+SVGAltGlyphElement::IsEventAttributeName(nsIAtom* aName)
 {
   return nsContentUtils::IsEventAttributeName(aName, EventNameType_SVGGraphic);
 }
 
+//----------------------------------------------------------------------
+// nsSVGElement overrides
+
 nsSVGElement::StringAttributesInfo
 SVGAltGlyphElement::GetStringInfo()
 {
   return StringAttributesInfo(mStringAttributes, sStringInfo,
                               ArrayLength(sStringInfo));
 }
 
 } // namespace dom
--- a/content/svg/content/src/SVGAltGlyphElement.h
+++ b/content/svg/content/src/SVGAltGlyphElement.h
@@ -26,31 +26,30 @@ protected:
   virtual JSObject* WrapNode(JSContext *cx,
                              JS::Handle<JSObject*> scope) MOZ_OVERRIDE;
 
 public:
   // nsIContent interface
   NS_IMETHOD_(bool) IsAttributeMapped(const nsIAtom* aAttribute) const MOZ_OVERRIDE;
 
   virtual nsresult Clone(nsINodeInfo *aNodeInfo, nsINode **aResult) const MOZ_OVERRIDE;
+  virtual bool IsEventAttributeName(nsIAtom* aName) MOZ_OVERRIDE;
 
   // WebIDL
   already_AddRefed<nsIDOMSVGAnimatedString> Href();
   void GetGlyphRef(nsAString & aGlyphRef);
   void SetGlyphRef(const nsAString & aGlyphRef, ErrorResult& rv);
   void GetFormat(nsAString & aFormat);
   void SetFormat(const nsAString & aFormat, ErrorResult& rv);
 
 protected:
 
   // nsSVGElement overrides
   virtual StringAttributesInfo GetStringInfo() MOZ_OVERRIDE;
 
-  virtual bool IsEventName(nsIAtom* aName);
-
   enum { HREF };
   nsSVGString mStringAttributes[1];
   static StringInfo sStringInfo[1];
 
 };
 
 } // namespace dom
 } // namespace mozilla
--- a/content/svg/content/src/SVGTSpanElement.cpp
+++ b/content/svg/content/src/SVGTSpanElement.cpp
@@ -47,19 +47,16 @@ SVGTSpanElement::IsAttributeMapped(const
     sGraphicsMap,
     sTextContentElementsMap
   };
 
   return FindAttributeDependence(name, map) ||
     SVGTSpanElementBase::IsAttributeMapped(name);
 }
 
-//----------------------------------------------------------------------
-// nsSVGElement overrides
-
 bool
-SVGTSpanElement::IsEventName(nsIAtom* aName)
+SVGTSpanElement::IsEventAttributeName(nsIAtom* aName)
 {
   return nsContentUtils::IsEventAttributeName(aName, EventNameType_SVGGraphic);
 }
 
 } // namespace dom
 } // namespace mozilla
--- a/content/svg/content/src/SVGTSpanElement.h
+++ b/content/svg/content/src/SVGTSpanElement.h
@@ -25,18 +25,16 @@ protected:
   virtual JSObject* WrapNode(JSContext *cx,
                              JS::Handle<JSObject*> scope) MOZ_OVERRIDE;
 
 public:
   // nsIContent interface
   NS_IMETHOD_(bool) IsAttributeMapped(const nsIAtom* aAttribute) const MOZ_OVERRIDE;
 
   virtual nsresult Clone(nsINodeInfo *aNodeInfo, nsINode **aResult) const MOZ_OVERRIDE;
-protected:
 
-  // nsSVGElement overrides
-  virtual bool IsEventName(nsIAtom* aName);
+  virtual bool IsEventAttributeName(nsIAtom* aName) MOZ_OVERRIDE;
 };
 
 } // namespace dom
 } // namespace mozilla
 
 #endif // mozilla_dom_SVGTSpanElement_h