Bug 1380081 - Part 10: Stop running BHR on beta, r=froydnj
authorMichael Layzell <michael@thelayzells.com>
Thu, 20 Jul 2017 14:40:46 -0400
changeset 374839 d3910f43605c9c130313d8e1d02063eb7b5ff760
parent 374838 07452b30b4dc41361f6f7a9e02ebce3509fbe79a
child 374840 5eb62a558dc1c929b58563de09b2c5f24dd9efc4
push id93781
push usermichael@thelayzells.com
push dateTue, 15 Aug 2017 20:37:28 +0000
treeherdermozilla-inbound@ebd9e87fae8d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1380081
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1380081 - Part 10: Stop running BHR on beta, r=froydnj These changes are going to increase the amount of data which we collect from BHR a lot. It would be dangerous to run it on beta, especially considering how soon the next merge is. This should turn it off for 100% of beta users if I understand the logic correctly. MozReview-Commit-ID: 3HyEKWdXaqU
toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
--- a/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
+++ b/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
@@ -25,19 +25,20 @@
 #include "nsXULAppAPI.h"
 #include "GeckoProfiler.h"
 #include "nsNetCID.h"
 #include "HangDetails.h"
 
 #include <algorithm>
 
 // Activate BHR only for one every BHR_BETA_MOD users.
-// This is now 100% of Beta population for the Beta 45/46 e10s A/B trials
-// It can be scaled back again in the future
-#define BHR_BETA_MOD 1;
+// We're doing experimentation with collecting a lot more data from BHR, and
+// don't want to enable it for beta users at the moment. We can scale this up in
+// the future.
+#define BHR_BETA_MOD INT32_MAX;
 
 // Maximum depth of the call stack in the reported thread hangs. This value represents
 // the 99.9th percentile of the thread hangs stack depths reported by Telemetry.
 static const size_t kMaxThreadHangStackDepth = 30;
 
 // An utility comparator function used by std::unique to collapse "(* script)" entries in
 // a vector representing a call stack.
 bool StackScriptEntriesCollapser(const char* aStackEntry, const char *aAnotherStackEntry)