Bug 800612 - actually increase WebGL element array test repetitions, patch didnt apply cleanly - r=jgilbert
authorBenoit Jacob <bjacob@mozilla.com>
Fri, 09 Nov 2012 20:49:15 -0500
changeset 112910 d33f050f2f34db7976ca504b5c6c5c55037e86a3
parent 112909 bc88f16024687b689538c48e4b6941c1f80604ef
child 112911 fe44be80d09f7d2c96fb2c9a25821ce19a3a96db
push id17827
push userbjacob@mozilla.com
push dateSat, 10 Nov 2012 01:49:24 +0000
treeherdermozilla-inbound@d33f050f2f34 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgilbert
bugs800612
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 800612 - actually increase WebGL element array test repetitions, patch didnt apply cleanly - r=jgilbert
content/canvas/compiledtest/TestWebGLElementArrayCache.cpp
--- a/content/canvas/compiledtest/TestWebGLElementArrayCache.cpp
+++ b/content/canvas/compiledtest/TestWebGLElementArrayCache.cpp
@@ -123,17 +123,22 @@ int main(int argc, char *argv[])
 
   CheckSanity<uint8_t>();
   CheckSanity<uint16_t>();
 
   nsTArray<uint8_t> v, vsub;
   WebGLElementArrayCache b;
 
   for (int maxBufferSize = 1; maxBufferSize <= 4096; maxBufferSize *= 2) {
-    int repeat = std::min(maxBufferSize, 20);
+    // See bug 800612. We originally had | repeat = min(maxBufferSize, 20) |
+    // and a real bug was only caught on Windows and not on Linux due to rand()
+    // producing different values. In that case, the minimum value by which to replace
+    // this 20 to reproduce the bug on Linux, was 25. Replacing it with 64 should give
+    // us some comfort margin.
+    int repeat = std::min(maxBufferSize, 64);
     for (int i = 0; i < repeat; i++) {
       size_t size = RandomInteger<size_t>(1, maxBufferSize);
       MakeRandomVector(v, size);
       b.BufferData(v.Elements(), size);
       CheckValidate(b, 0, size);
 
       for (int j = 0; j < 16; j++) {
         for (int bufferSubDataCalls = 1; bufferSubDataCalls <= 8; bufferSubDataCalls *= 2) {