author | Martin Stransky <stransky@redhat.com> |
Fri, 12 Oct 2018 16:16:50 +0000 | |
changeset 441064 | d2b32aa2055fecc143a03013b06afbac1ad91836 |
parent 441063 | 3df978f11b6d4017d88295335458283c38d697cd |
child 441065 | 74d5645c1fc68035f61d31cc93ccbe727fcb16fa |
push id | 108898 |
push user | aciure@mozilla.com |
push date | Sat, 13 Oct 2018 09:41:13 +0000 |
treeherder | mozilla-inbound@27ce80745049 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | dao |
bugs | 1498356 |
milestone | 64.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/widget/gtk/gtk3drawing.cpp +++ b/widget/gtk/gtk3drawing.cpp @@ -2566,16 +2566,23 @@ moz_gtk_get_widget_border(WidgetNodeType left, top, right, bottom); GtkStyleContext* labelStyle = GetStyleContext(MOZ_GTK_TOOLTIP_BOX_LABEL); moz_gtk_add_margin_border_padding(labelStyle, left, top, right, bottom); return MOZ_GTK_SUCCESS; } + case MOZ_GTK_HEADER_BAR_BUTTON_BOX: + { + style = GetStyleContext(MOZ_GTK_HEADER_BAR); + moz_gtk_add_border_padding(style, left, top, right, bottom); + *top = *bottom = 0; + return MOZ_GTK_SUCCESS; + } /* These widgets have no borders, since they are not containers. */ case MOZ_GTK_CHECKBUTTON_LABEL: case MOZ_GTK_RADIOBUTTON_LABEL: case MOZ_GTK_SPLITTER_HORIZONTAL: case MOZ_GTK_SPLITTER_VERTICAL: case MOZ_GTK_CHECKBUTTON: case MOZ_GTK_RADIOBUTTON: case MOZ_GTK_SCROLLBAR_BUTTON:
--- a/widget/gtk/gtkdrawing.h +++ b/widget/gtk/gtkdrawing.h @@ -322,16 +322,18 @@ typedef enum { /* Paints a GtkComboBox entry arrow widget. */ MOZ_GTK_COMBOBOX_ENTRY_ARROW, /* Used for scrolled window shell. */ MOZ_GTK_SCROLLED_WINDOW, /* Paints a GtkHeaderBar */ MOZ_GTK_HEADER_BAR, /* Paints a GtkHeaderBar in maximized state */ MOZ_GTK_HEADER_BAR_MAXIMIZED, + /* Container for GtkHeaderBar buttons */ + MOZ_GTK_HEADER_BAR_BUTTON_BOX, /* Paints GtkHeaderBar title buttons. * Keep the order here as MOZ_GTK_HEADER_BAR_BUTTON_* are processed * as an array from MOZ_GTK_HEADER_BAR_BUTTON_CLOSE to the last one. */ MOZ_GTK_HEADER_BAR_BUTTON_CLOSE, MOZ_GTK_HEADER_BAR_BUTTON_MINIMIZE, MOZ_GTK_HEADER_BAR_BUTTON_MAXIMIZE,
--- a/widget/gtk/nsNativeThemeGTK.cpp +++ b/widget/gtk/nsNativeThemeGTK.cpp @@ -795,16 +795,19 @@ nsNativeThemeGTK::GetGtkWidgetAndState(S aGtkWidgetType = MOZ_GTK_INFO_BAR; break; case StyleAppearance::MozWindowTitlebar: aGtkWidgetType = MOZ_GTK_HEADER_BAR; break; case StyleAppearance::MozWindowTitlebarMaximized: aGtkWidgetType = MOZ_GTK_HEADER_BAR_MAXIMIZED; break; + case StyleAppearance::MozWindowButtonBox: + aGtkWidgetType = MOZ_GTK_HEADER_BAR_BUTTON_BOX; + break; case StyleAppearance::MozWindowButtonClose: aGtkWidgetType = MOZ_GTK_HEADER_BAR_BUTTON_CLOSE; break; case StyleAppearance::MozWindowButtonMinimize: aGtkWidgetType = MOZ_GTK_HEADER_BAR_BUTTON_MINIMIZE; break; case StyleAppearance::MozWindowButtonMaximize: aGtkWidgetType = MOZ_GTK_HEADER_BAR_BUTTON_MAXIMIZE; @@ -1430,16 +1433,17 @@ nsNativeThemeGTK::GetWidgetPadding(nsDev if (aWidgetType == StyleAppearance::MenulistButton && StaticPrefs::layout_css_webkit_appearance_enabled()) { aWidgetType = StyleAppearance::Menulist; } switch (aWidgetType) { case StyleAppearance::ButtonFocus: case StyleAppearance::Toolbarbutton: + case StyleAppearance::MozWindowButtonBox: case StyleAppearance::MozWindowButtonClose: case StyleAppearance::MozWindowButtonMinimize: case StyleAppearance::MozWindowButtonMaximize: case StyleAppearance::MozWindowButtonRestore: case StyleAppearance::Dualbutton: case StyleAppearance::TabScrollArrowBack: case StyleAppearance::TabScrollArrowForward: case StyleAppearance::MenulistButton: @@ -2011,16 +2015,17 @@ nsNativeThemeGTK::ThemeSupportsWidget(ns case StyleAppearance::Splitter: case StyleAppearance::Window: case StyleAppearance::Dialog: #ifdef MOZ_WIDGET_GTK case StyleAppearance::MozGtkInfoBar: #endif return !IsWidgetStyled(aPresContext, aFrame, aWidgetType); + case StyleAppearance::MozWindowButtonBox: case StyleAppearance::MozWindowButtonClose: case StyleAppearance::MozWindowButtonMinimize: case StyleAppearance::MozWindowButtonMaximize: case StyleAppearance::MozWindowButtonRestore: case StyleAppearance::MozWindowTitlebar: case StyleAppearance::MozWindowTitlebarMaximized: // GtkHeaderBar is available on GTK 3.10+, which is used for styling // title bars and title buttons.