Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow
authorPaul Bone <pbone@mozilla.com>
Thu, 14 Nov 2019 00:12:58 +0000
changeset 501915 d21a794140eaf8f83113afa6346d352596292e9b
parent 501914 ba1518c4b5e817c3cce93185afc5cebf3092dfde
child 501916 8e2a3741f1bfd1e65febf8ecf99757ae2462126d
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1593545
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52804
netwerk/protocol/http/nsHttpChannel.cpp
--- a/netwerk/protocol/http/nsHttpChannel.cpp
+++ b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -2588,16 +2588,25 @@ nsresult nsHttpChannel::ContinueProcessR
   return ContinueProcessResponse2(rv);
 }
 
 void nsHttpChannel::AssertNotDocumentChannel() {
   if (!mLoadInfo || !IsDocument()) {
     return;
   }
 
+#ifndef DEBUG
+  if (!StaticPrefs::fission_autostart()) {
+    // This assertion is firing in the wild (Bug 1593545) and its not clear
+    // why. Disable the assertion in non-fission non-debug configurations to
+    // avoid crashing user's browsers until we're done dogfooding fission.
+    return;
+  }
+#endif
+
   nsCOMPtr<nsIParentChannel> parentChannel;
   NS_QueryNotificationCallbacks(this, parentChannel);
   RefPtr<DocumentChannelParent> documentChannelParent =
       do_QueryObject(parentChannel);
   if (documentChannelParent) {
     // The load is using document channel.
     return;
   }