Bug 1196430 follow-up: Hide the usage of gCodeAddressService behind #ifdef MOZ_STACKWALKING
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 11 Sep 2015 00:06:40 -0400
changeset 261878 d1ae50174aea2a8a97a49447b851e46652d85002
parent 261877 67ce03afe256ee5ffb9aaf6e666e4f033c101a08
child 261879 28f1e57d47573b0c78e67221df93148111c24e2a
push id64865
push usereakhgari@mozilla.com
push dateFri, 11 Sep 2015 04:06:53 +0000
treeherdermozilla-inbound@d1ae50174aea [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1196430
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1196430 follow-up: Hide the usage of gCodeAddressService behind #ifdef MOZ_STACKWALKING This is needed to fix the build bustage on B2G Desktop Windows. Landed on a CLOSED TREE
xpcom/base/nsTraceRefcnt.cpp
--- a/xpcom/base/nsTraceRefcnt.cpp
+++ b/xpcom/base/nsTraceRefcnt.cpp
@@ -475,28 +475,30 @@ DumpSerialNumbers(PLHashEntry* aHashEntr
           record->COMPtrCount);
 #else
   fprintf(outputFile, "%" PRIdPTR
           " @%p (%d references)\n",
           record->serialNumber,
           NS_INT32_TO_PTR(aHashEntry->key),
           record->refCount);
 #endif
+#ifdef MOZ_STACKWALKING
   if (!record->allocationStack.empty()) {
     static const size_t bufLen = 1024;
     char buf[bufLen];
     fprintf(outputFile, "allocation stack:\n");
     for (size_t i = 0, length = record->allocationStack.size();
          i < length;
          ++i) {
       gCodeAddressService->GetLocation(i, record->allocationStack[i],
                                        buf, bufLen);
       fprintf(outputFile, "%s\n", buf);
     }
   }
+#endif
   return HT_ENUMERATE_NEXT;
 }
 
 
 template<>
 class nsDefaultComparator<BloatEntry*, BloatEntry*>
 {
 public: