Backed out changeset 08c9beb155d5 (bug 1450360) for build bustages at builds/worker/workspace/build/src/layout/painting/RetainedDisplayListBuilder.cpp:1118 on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Wed, 04 Apr 2018 02:22:21 +0300
changeset 411637 d112cf7b2b60e6244099dc3b599a2444ba0d1da3
parent 411636 f04ea50a6c1390dc9c5342dc78eca432cdb76d95
child 411638 d5135503f825e3d0772bf4617bd80f002bafaaab
push id101712
push userebalazs@mozilla.com
push dateWed, 04 Apr 2018 09:52:15 +0000
treeherdermozilla-inbound@dd31fb345c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1450360
milestone61.0a1
backs out08c9beb155d5233f1e57073b44e9175ef6231de3
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 08c9beb155d5 (bug 1450360) for build bustages at builds/worker/workspace/build/src/layout/painting/RetainedDisplayListBuilder.cpp:1118 on a CLOSED TREE
layout/painting/RetainedDisplayListBuilder.cpp
--- a/layout/painting/RetainedDisplayListBuilder.cpp
+++ b/layout/painting/RetainedDisplayListBuilder.cpp
@@ -990,24 +990,16 @@ RetainedDisplayListBuilder::AttemptParti
   AutoClearFramePropsArray modifiedFrames;
   AutoClearFramePropsArray framesWithProps;
   GetModifiedAndFramesWithProps(&mBuilder, &modifiedFrames.Frames(), &framesWithProps.Frames());
 
   // Do not allow partial builds if the retained display list is empty, or if
   // ShouldBuildPartial heuristic fails.
   const bool shouldBuildPartial = !mList.IsEmpty() && ShouldBuildPartial(modifiedFrames.Frames());
 
-  // We don't support retaining with overlay scrollbars, since they require
-  // us to look at the display list and pick the highest z-index, which
-  // we can't do during partial building.
-  if (mBuilder.BuiltOverlayScrollbars()) {
-    shouldBuildPartial = false;
-    mBuilder.SetBuiltOverlayScrollbars(false);
-  }
-
   if (mPreviousCaret != mBuilder.GetCaretFrame()) {
     if (mPreviousCaret) {
       if (mBuilder.MarkFrameModifiedDuringBuilding(mPreviousCaret)) {
         modifiedFrames.Frames().AppendElement(mPreviousCaret);
       }
     }
 
     if (mBuilder.GetCaretFrame()) {