Bug 1497393 Part 3 - Remove ReplayDebuggerObject.global, r=loganfsmyth.
authorBrian Hackett <bhackett1024@gmail.com>
Sat, 09 Mar 2019 16:39:02 -1000
changeset 468287 d0c8809342e494ce691699f7cadae2f872f6700d
parent 468286 b23b6d4643d7c3df30ff36a8adf7c4dc4697d35d
child 468288 47c9d34dbef10537efde4d8915571307812a6283
push id112699
push userbhackett@mozilla.com
push dateSun, 07 Apr 2019 03:06:36 +0000
treeherdermozilla-inbound@46a995ea433f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersloganfsmyth
bugs1497393
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497393 Part 3 - Remove ReplayDebuggerObject.global, r=loganfsmyth. Differential Revision: https://phabricator.services.mozilla.com/D22859
devtools/server/actors/replay/debugger.js
devtools/server/actors/replay/replay.js
--- a/devtools/server/actors/replay/debugger.js
+++ b/devtools/server/actors/replay/debugger.js
@@ -937,17 +937,16 @@ ReplayDebuggerObject.prototype = {
   get name() { return this._data.name; },
   get displayName() { return this._data.displayName; },
   get parameterNames() { return this._data.parameterNames; },
   get script() { return this._dbg._getScript(this._data.script); },
   get environment() { return this._dbg._getObject(this._data.environment); },
   get boundTargetFunction() { return this.isBoundFunction ? NYI() : undefined; },
   get boundThis() { return this.isBoundFunction ? NYI() : undefined; },
   get boundArguments() { return this.isBoundFunction ? NYI() : undefined; },
-  get global() { return this._dbg._getObject(this._data.global); },
   get isProxy() { return this._data.isProxy; },
   get proto() { return this._dbg._getObject(this._data.proto); },
 
   isExtensible() { return this._data.isExtensible; },
   isSealed() { return this._data.isSealed; },
   isFrozen() { return this._data.isFrozen; },
 
   unsafeDereference() {
--- a/devtools/server/actors/replay/replay.js
+++ b/devtools/server/actors/replay/replay.js
@@ -672,17 +672,16 @@ const gRequestHandlers = {
         isAsyncFunction: object.isAsyncFunction,
         proto: getObjectId(object.proto),
         class: object.class,
         name: object.name,
         displayName: object.displayName,
         parameterNames: object.parameterNames,
         script: gScripts.getId(object.script),
         environment: getObjectId(object.environment),
-        global: getObjectId(object.global),
         isProxy: object.isProxy,
         isExtensible: object.isExtensible(),
         isSealed: object.isSealed(),
         isFrozen: object.isFrozen(),
       };
     }
     if (object instanceof Debugger.Environment) {
       return {