Bug 1591989 - [remote] Don't use 'frameId' for Page.loadEventFired event. r=whimboo,remote-protocol-reviewers
authorJaStenson <jacob@nosnets.co.uk>
Thu, 14 Nov 2019 21:22:16 +0000
changeset 502035 d0af2df439cdf6c7e153a2f4e209b0a110f20bd4
parent 502034 f7d3a6261cb34b81f7382a917069a4ed84e573a7
child 502039 b128903fea7457452171d43c599a6d67719eb3d9
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswhimboo, remote-protocol-reviewers
bugs1591989
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1591989 - [remote] Don't use 'frameId' for Page.loadEventFired event. r=whimboo,remote-protocol-reviewers Differential Revision: https://phabricator.services.mozilla.com/D53046
remote/domains/content/Page.jsm
--- a/remote/domains/content/Page.jsm
+++ b/remote/domains/content/Page.jsm
@@ -147,17 +147,17 @@ class Page extends ContentProcessDomain 
     const url = target.location.href;
 
     switch (type) {
       case "DOMContentLoaded":
         this.emit("Page.domContentEventFired", { timestamp });
         break;
 
       case "pageshow":
-        this.emit("Page.loadEventFired", { timestamp, frameId });
+        this.emit("Page.loadEventFired", { timestamp });
         // XXX this should most likely be sent differently
         this.emit("Page.navigatedWithinDocument", { frameId, url });
         this.emit("Page.frameStoppedLoading", { frameId });
         break;
     }
   }
 }