Bug 1123111 - Mark EventNameMapping::mAtom as non-owning; r=smaug
authorEhsan Akhgari <ehsan@mozilla.com>
Sun, 18 Jan 2015 14:01:31 -0500
changeset 224458 cf2d52a26ec2915bfa34e1ab5a2470f7747c2b0b
parent 224457 953aecc38f56cf797438209af38be82a574e4d8b
child 224459 fae8ad41a60416696c88968265cb7baef87bd648
push id54233
push usereakhgari@mozilla.com
push dateSun, 18 Jan 2015 23:44:01 +0000
treeherdermozilla-inbound@cf2d52a26ec2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1123111
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1123111 - Mark EventNameMapping::mAtom as non-owning; r=smaug
dom/base/nsContentUtils.h
--- a/dom/base/nsContentUtils.h
+++ b/dom/base/nsContentUtils.h
@@ -150,17 +150,19 @@ enum EventNameType {
   EventNameType_HTMLBodyOrFramesetOnly = 0x0020,
 
   EventNameType_HTMLXUL = 0x0003,
   EventNameType_All = 0xFFFF
 };
 
 struct EventNameMapping
 {
-  nsIAtom* mAtom;
+  // This holds pointers to nsGkAtoms members, and is therefore safe as a
+  // non-owning reference.
+  nsIAtom* MOZ_OWNING_REF mAtom;
   uint32_t mId;
   int32_t  mType;
   mozilla::EventClassID mEventClassID;
 };
 
 struct nsShortcutCandidate {
   nsShortcutCandidate(uint32_t aCharCode, bool aIgnoreShift) :
     mCharCode(aCharCode), mIgnoreShift(aIgnoreShift)