Bug 1596868 - CXXFLAGS, LDFLAGS, etc. regressed by bug 1595906 r=firefox-build-system-reviewers,dmajor
authorRicky Stewart <rstewart@mozilla.com>
Fri, 15 Nov 2019 18:34:50 +0000
changeset 502260 cee8f503d3c32d97955c077405880439c6c2a365
parent 502259 da344ab046b6ec344be2595752224d8ebc848b27
child 502261 f3ce2609c3f30a4473054e4a76fd96e735c46176
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfirefox-build-system-reviewers, dmajor
bugs1596868, 1595906
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596868 - CXXFLAGS, LDFLAGS, etc. regressed by bug 1595906 r=firefox-build-system-reviewers,dmajor Differential Revision: https://phabricator.services.mozilla.com/D53249
python/mozbuild/mozbuild/frontend/context.py
--- a/python/mozbuild/mozbuild/frontend/context.py
+++ b/python/mozbuild/mozbuild/frontend/context.py
@@ -399,17 +399,17 @@ class LinkFlags(BaseCompileFlags):
         self._context = context
 
         self.flag_variables = (
             ('OS', self._os_ldflags(), ('LDFLAGS',)),
             ('MOZ_HARDENING_LDFLAGS',
              (context.config.substs.get('MOZ_HARDENING_LDFLAGS_JS')
               if _context_under_js_src(context) else
               context.config.substs.get('MOZ_HARDENING_LDFLAGS')),
-             ('LDFLAGS')),
+             ('LDFLAGS',)),
             ('DEFFILE', None, ('LDFLAGS',)),
             ('MOZBUILD', None, ('LDFLAGS',)),
             ('FIX_LINK_PATHS', context.config.substs.get('MOZ_FIX_LINK_PATHS'),
              ('LDFLAGS',)),
             ('OPTIMIZE', (context.config.substs.get('MOZ_OPTIMIZE_LDFLAGS', []) if
                           context.config.substs.get('MOZ_OPTIMIZE') else []),
              ('LDFLAGS',)),
         )