author | Neil Rashbrook <neil@parkwaycc.co.uk> |
Tue, 11 May 2010 10:48:10 +0100 | |
changeset 42124 | ce9f07472020dbac7cb53418831c22fefcff260d |
parent 42123 | aa0171d3680585f5afb0b39607633cce8348d5ba |
child 42125 | 250c2418be7a28dc240b20d1894e8ce2f7634e60 |
push id | unknown |
push user | unknown |
push date | unknown |
reviewers | surkov, davidb |
bugs | 561734 |
milestone | 1.9.3a5pre |
first release with | nightly linux32
ce9f07472020
/
3.7a5pre
/
20100511030252
/
files
nightly linux64
ce9f07472020
/
3.7a5pre
/
20100511030703
/
files
nightly mac
ce9f07472020
/
3.7a5pre
/
20100511030640
/
files
nightly win32
ce9f07472020
/
3.7a5pre
/
20100511040317
/
files
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
|
releases | nightly linux32
3.7a5pre
/
20100511030252
/
pushlog to previous
nightly linux64
3.7a5pre
/
20100511030703
/
pushlog to previous
nightly mac
3.7a5pre
/
20100511030640
/
pushlog to previous
nightly win32
3.7a5pre
/
20100511040317
/
pushlog to previous
|
--- a/accessible/src/base/nsAccUtils.cpp +++ b/accessible/src/base/nsAccUtils.cpp @@ -118,17 +118,17 @@ nsAccUtils::GetDefaultLevel(nsAccessible } return 0; } PRInt32 nsAccUtils::GetARIAOrDefaultLevel(nsIAccessible *aAcc) { - nsRefPtr<nsAccessible> acc = nsAccUtils::QueryObject<nsAccessible>(aAcc); + nsRefPtr<nsAccessible> acc = do_QueryObject(aAcc); NS_ENSURE_TRUE(acc, 0); nsCOMPtr<nsIDOMNode> node; acc->GetDOMNode(getter_AddRefs(node)); nsCOMPtr<nsIContent> content(do_QueryInterface(node)); NS_ENSURE_TRUE(content, 0); PRInt32 level = 0;
--- a/accessible/src/base/nsAccUtils.h +++ b/accessible/src/base/nsAccUtils.h @@ -314,47 +314,16 @@ public: * * @param aRule [in] rule constant (see ELiveAttrRule in nsAccMap.h) * @param aValue [out] object attribute value * * @return true if object attribute should be exposed */ static PRBool GetLiveAttrValue(PRUint32 aRule, nsAString& aValue); - /** - * Query DestinationType from the given SourceType. - */ - template<class DestinationType, class SourceType> static inline - already_AddRefed<DestinationType> QueryObject(SourceType *aObject) - { - DestinationType* object = nsnull; - if (aObject) - CallQueryInterface(aObject, &object); - - return object; - } - template<class DestinationType, class SourceType> static inline - already_AddRefed<DestinationType> QueryObject(nsCOMPtr<SourceType>& aObject) - { - DestinationType* object = nsnull; - if (aObject) - CallQueryInterface(aObject, &object); - - return object; - } - template<class DestinationType, class SourceType> static inline - already_AddRefed<DestinationType> QueryObject(nsRefPtr<SourceType>& aObject) - { - DestinationType* object = nsnull; - if (aObject) - CallQueryInterface(aObject.get(), &object); - - return object; - } - #ifdef DEBUG_A11Y /** * Detect whether the given accessible object implements nsIAccessibleText, * when it is text or has text child node. */ static PRBool IsTextInterfaceSupportCorrect(nsIAccessible *aAccessible); #endif
--- a/accessible/src/base/nsAccessNode.cpp +++ b/accessible/src/base/nsAccessNode.cpp @@ -396,18 +396,17 @@ nsAccessNode::IsInCache() nsAccessNode::GetDocAccessibleFor(mWeakShell); if (!accessibleDoc) return nsnull; void* uniqueID = nsnull; GetUniqueID(&uniqueID); - nsRefPtr<nsDocAccessible> docAccessible = - nsAccUtils::QueryObject<nsDocAccessible>(accessibleDoc); + nsRefPtr<nsDocAccessible> docAccessible = do_QueryObject(accessibleDoc); return docAccessible->GetCachedAccessNode(uniqueID) ? PR_TRUE : PR_FALSE; } #endif //////////////////////////////////////////////////////////////////////////////// // nsIAccessNode NS_IMETHODIMP
--- a/accessible/src/base/nsAccessibilityService.cpp +++ b/accessible/src/base/nsAccessibilityService.cpp @@ -982,18 +982,17 @@ nsAccessibilityService::GetCachedAccessN nsIWeakReference *aWeakShell) { nsCOMPtr<nsIAccessibleDocument> accessibleDoc = nsAccessNode::GetDocAccessibleFor(aWeakShell); if (!accessibleDoc) return nsnull; - nsRefPtr<nsDocAccessible> docAccessible = - nsAccUtils::QueryObject<nsDocAccessible>(accessibleDoc); + nsRefPtr<nsDocAccessible> docAccessible = do_QueryObject(accessibleDoc); return docAccessible->GetCachedAccessNode(static_cast<void*>(aNode)); } //////////////////////////////////////////////////////////////////////////////// // nsIAccessibleRetrieval NS_IMETHODIMP nsAccessibilityService::GetApplicationAccessible(nsIAccessible **aAccessibleApplication) @@ -1341,18 +1340,17 @@ nsAccessibilityService::GetAccessible(ns #endif // Check to see if we already have an accessible for this node in the cache. nsAccessNode* cachedAccessNode = GetCachedAccessNode(aNode, aWeakShell); if (cachedAccessNode) { // XXX: the cache might contain the access node for the DOM node that is not // accessible because of wrong cache update. In this case try to create new // accessible. - nsRefPtr<nsAccessible> cachedAccessible = - nsAccUtils::QueryObject<nsAccessible>(cachedAccessNode); + nsRefPtr<nsAccessible> cachedAccessible = do_QueryObject(cachedAccessNode); if (cachedAccessible) return cachedAccessible.forget(); } // No cache entry, so we must create the accessible. nsRefPtr<nsAccessible> newAcc; @@ -1426,17 +1424,17 @@ nsAccessibilityService::GetAccessible(ns return nsnull; } } if (weakFrame.IsAlive()) { nsCOMPtr<nsIAccessible> newAccessible; weakFrame.GetFrame()->GetAccessible(getter_AddRefs(newAccessible)); if (newAccessible) { - newAcc = nsAccUtils::QueryObject<nsAccessible>(newAccessible); + newAcc = do_QueryObject(newAccessible); if (InitAccessible(newAcc, nsnull)) return newAcc.forget(); return nsnull; } } return nsnull; } @@ -1594,17 +1592,17 @@ nsAccessibilityService::GetAccessible(ns *aIsHidden = PR_TRUE; return nsnull; } // Try using frame to do it. nsCOMPtr<nsIAccessible> newAccessible; f->GetAccessible(getter_AddRefs(newAccessible)); - newAcc = nsAccUtils::QueryObject<nsAccessible>(newAccessible); + newAcc = do_QueryObject(newAccessible); } } } if (!newAcc) { // Elements may implement nsIAccessibleProvider via XBL. This allows them to // say what kind of accessible to create. newAcc = CreateAccessibleByType(aNode, aWeakShell); @@ -1763,38 +1761,37 @@ nsAccessibilityService::GetAreaAccessibl // Try to get image map accessible from the global cache or create it // if failed. nsRefPtr<nsAccessible> imageAcc; nsCOMPtr<nsIDOMNode> imageNode(do_QueryInterface(aImageFrame->GetContent())); nsAccessNode *cachedImgAcc = GetCachedAccessNode(imageNode, aWeakShell); if (cachedImgAcc) - imageAcc = nsAccUtils::QueryObject<nsAccessible>(cachedImgAcc); + imageAcc = do_QueryObject(cachedImgAcc); if (!imageAcc) { nsCOMPtr<nsIAccessible> imageAccessible; CreateHTMLImageAccessible(aImageFrame, getter_AddRefs(imageAccessible)); - imageAcc = nsAccUtils::QueryObject<nsAccessible>(imageAccessible); + imageAcc = do_QueryObject(imageAccessible); if (!InitAccessible(imageAcc, nsnull)) return nsnull; } // Make sure <area> accessible children of the image map are cached so // that they should be available in global cache. imageAcc->EnsureChildren(); nsAccessNode *cachedAreaAcc = GetCachedAccessNode(aAreaNode, aWeakShell); if (!cachedAreaAcc) return nsnull; - nsRefPtr<nsAccessible> areaAcc = - nsAccUtils::QueryObject<nsAccessible>(cachedAreaAcc); + nsRefPtr<nsAccessible> areaAcc = do_QueryObject(cachedAreaAcc); return areaAcc.forget(); } already_AddRefed<nsAccessible> nsAccessibilityService::CreateAccessibleByType(nsIDOMNode *aNode, nsIWeakReference *aWeakShell) { nsCOMPtr<nsIAccessibleProvider> accessibleProvider(do_QueryInterface(aNode));
--- a/accessible/src/base/nsAccessible.cpp +++ b/accessible/src/base/nsAccessible.cpp @@ -170,18 +170,17 @@ nsresult nsAccessible::QueryInterface(RE if (mRoleMapEntry && mRoleMapEntry->valueRule != eNoValue) { *aInstancePtr = static_cast<nsIAccessibleValue*>(this); NS_ADDREF_THIS(); return NS_OK; } } if (aIID.Equals(NS_GET_IID(nsIAccessibleHyperLink))) { - nsCOMPtr<nsIAccessibleHyperText> hyperTextParent = - nsAccUtils::QueryObject<nsIAccessibleHyperText>(GetParent()); + nsCOMPtr<nsIAccessibleHyperText> hyperTextParent = do_QueryObject(GetParent()); if (hyperTextParent) { *aInstancePtr = static_cast<nsIAccessibleHyperLink*>(this); NS_ADDREF_THIS(); return NS_OK; } return NS_ERROR_NO_INTERFACE; }
--- a/accessible/src/base/nsApplicationAccessible.cpp +++ b/accessible/src/base/nsApplicationAccessible.cpp @@ -319,18 +319,17 @@ nsApplicationAccessible::GetSiblingAtOff //////////////////////////////////////////////////////////////////////////////// // Public methods nsresult nsApplicationAccessible::AddRootAccessible(nsIAccessible *aRootAccessible) { NS_ENSURE_ARG_POINTER(aRootAccessible); - nsRefPtr<nsAccessible> rootAcc = - nsAccUtils::QueryObject<nsAccessible>(aRootAccessible); + nsRefPtr<nsAccessible> rootAcc = do_QueryObject(aRootAccessible); if (!mChildren.AppendElement(rootAcc)) return NS_ERROR_FAILURE; rootAcc->SetParent(this); return NS_OK; }
--- a/accessible/src/base/nsBaseWidgetAccessible.cpp +++ b/accessible/src/base/nsBaseWidgetAccessible.cpp @@ -207,18 +207,17 @@ nsLinkableAccessible::GetKeyboardShortcu // nsLinkableAccessible. nsIAccessibleHyperLink NS_IMETHODIMP nsLinkableAccessible::GetURI(PRInt32 aIndex, nsIURI **aURI) { if (mIsLink) { nsRefPtr<nsAccessible> actionAcc = GetActionAccessible(); if (actionAcc) { - nsCOMPtr<nsIAccessibleHyperLink> hyperLinkAcc = - nsAccUtils::QueryObject<nsIAccessibleHyperLink>(actionAcc); + nsCOMPtr<nsIAccessibleHyperLink> hyperLinkAcc = do_QueryObject(actionAcc); NS_ASSERTION(hyperLinkAcc, "nsIAccessibleHyperLink isn't implemented."); if (hyperLinkAcc) return hyperLinkAcc->GetURI(aIndex, aURI); } }
--- a/accessible/src/base/nsDocAccessible.cpp +++ b/accessible/src/base/nsDocAccessible.cpp @@ -544,18 +544,17 @@ nsDocAccessible::GetCachedAccessNode(voi accessNode = this; } #ifdef DEBUG // All cached accessible nodes should be in the parent // It will assert if not all the children were created // when they were first cached, and no invalidation // ever corrected parent accessible's child cache. - nsRefPtr<nsAccessible> acc = - nsAccUtils::QueryObject<nsAccessible>(accessNode); + nsRefPtr<nsAccessible> acc = do_QueryObject(accessNode); if (acc) { nsAccessible* parent(acc->GetCachedParent()); if (parent) parent->TestChildCache(acc); } #endif @@ -1413,17 +1412,17 @@ nsDocAccessible::GetParent() if (accService) { // XXX aaronl: ideally we would traverse the presshell chain. Since // there's no easy way to do that, we cheat and use the document // hierarchy. GetAccessibleFor() is bad because it doesn't support our // concept of multiple presshells per doc. // It should be changed to use GetAccessibleInWeakShell() nsCOMPtr<nsIAccessible> parent; accService->GetAccessibleFor(ownerNode, getter_AddRefs(parent)); - mParent = nsAccUtils::QueryObject<nsAccessible>(parent); + mParent = do_QueryObject(parent); } } NS_ASSERTION(mParent, "No parent for not root document accessible!"); return mParent; } @@ -1766,18 +1765,17 @@ nsDocAccessible::ProcessPendingEvent(nsA } } } } } void nsDocAccessible::InvalidateChildrenInSubtree(nsIDOMNode *aStartNode) { - nsRefPtr<nsAccessible> acc = - nsAccUtils::QueryObject<nsAccessible>(GetCachedAccessNode(aStartNode)); + nsRefPtr<nsAccessible> acc = do_QueryObject(GetCachedAccessNode(aStartNode)); if (acc) acc->InvalidateChildren(); // Invalidate accessible children in the DOM subtree nsCOMPtr<nsINode> node = do_QueryInterface(aStartNode); PRInt32 index, numChildren = node->GetChildCount(); for (index = 0; index < numChildren; index ++) { nsCOMPtr<nsIDOMNode> childNode = do_QueryInterface(node->GetChildAt(index)); @@ -1791,18 +1789,17 @@ void nsDocAccessible::RefreshNodes(nsIDO if (mAccessNodeCache.Count() <= 1) { return; // All we have is a doc accessible. There is nothing to invalidate, quit early } nsRefPtr<nsAccessNode> accessNode = GetCachedAccessNode(aStartNode); // Shut down accessible subtree, which may have been created for // anonymous content subtree - nsRefPtr<nsAccessible> accessible = - nsAccUtils::QueryObject<nsAccessible>(accessNode); + nsRefPtr<nsAccessible> accessible = do_QueryObject(accessNode); if (accessible) { // Fire menupopup end if a menu goes away PRUint32 role = nsAccUtils::Role(accessible); if (role == nsIAccessibleRole::ROLE_MENUPOPUP) { nsCOMPtr<nsIDOMNode> domNode; accessNode->GetDOMNode(getter_AddRefs(domNode)); nsCOMPtr<nsIDOMXULPopupElement> popup(do_QueryInterface(domNode)); if (!popup) {
--- a/accessible/src/base/nsEventShell.cpp +++ b/accessible/src/base/nsEventShell.cpp @@ -47,18 +47,17 @@ //////////////////////////////////////////////////////////////////////////////// void nsEventShell::FireEvent(nsAccEvent *aEvent) { if (!aEvent) return; - nsRefPtr<nsAccessible> acc = - nsAccUtils::QueryObject<nsAccessible>(aEvent->GetAccessible()); + nsRefPtr<nsAccessible> acc = do_QueryObject(aEvent->GetAccessible()); NS_ENSURE_TRUE(acc,); nsCOMPtr<nsIDOMNode> node; aEvent->GetDOMNode(getter_AddRefs(node)); if (node) { sEventTargetNode = node; sEventFromUserInput = aEvent->IsFromUserInput(); }
--- a/accessible/src/base/nsTextAccessible.cpp +++ b/accessible/src/base/nsTextAccessible.cpp @@ -56,17 +56,17 @@ nsTextAccessible::GetRoleInternal(PRUint *aRole = nsIAccessibleRole::ROLE_TEXT_LEAF; return NS_OK; } nsresult nsTextAccessible::AppendTextTo(nsAString& aText, PRUint32 aStartOffset, PRUint32 aLength) { nsIFrame *frame = GetFrame(); - NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE); + if (!frame) return NS_ERROR_FAILURE;//NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE); return frame->GetRenderedText(&aText, nsnull, nsnull, aStartOffset, aLength); } void nsTextAccessible::CacheChildren() { // No children for text accessible.
--- a/accessible/src/xforms/nsXFormsAccessible.cpp +++ b/accessible/src/xforms/nsXFormsAccessible.cpp @@ -131,17 +131,17 @@ nsXFormsAccessible::CacheSelectChildren( if (!child) continue; GetAccService()->GetAttachedAccessibleFor(child, getter_AddRefs(accessible)); if (!accessible) continue; - acc = nsAccUtils::QueryObject<nsAccessible>(accessible); + acc = do_QueryObject(accessible); mChildren.AppendElement(acc); acc->SetParent(this); } } // nsIAccessible NS_IMETHODIMP
--- a/accessible/src/xul/nsXULTreeAccessible.cpp +++ b/accessible/src/xul/nsXULTreeAccessible.cpp @@ -264,18 +264,17 @@ nsXULTreeAccessible::GetChildAtPoint(PRI // tree columns. if (row == -1 || !column) return nsXULSelectableAccessible:: GetChildAtPoint(aX, aY, aDeepestChild, aChild); nsAccessible *child = GetTreeItemAccessible(row); if (aDeepestChild && child) { // Look for accessible cell for the found item accessible. - nsRefPtr<nsXULTreeItemAccessibleBase> treeitem = - nsAccUtils::QueryObject<nsXULTreeItemAccessibleBase>(child); + nsRefPtr<nsXULTreeItemAccessibleBase> treeitem = do_QueryObject(child); nsAccessible *cell = treeitem->GetCellAccessible(column); if (cell) child = cell; } NS_IF_ADDREF(*aChild = child); return NS_OK; @@ -476,18 +475,17 @@ nsXULTreeAccessible::GetChildCount() } PRInt32 nsXULTreeAccessible::GetIndexOf(nsIAccessible *aChild) { if (IsDefunct()) return -1; - nsRefPtr<nsXULTreeItemAccessibleBase> item = - nsAccUtils::QueryObject<nsXULTreeItemAccessibleBase>(aChild); + nsRefPtr<nsXULTreeItemAccessibleBase> item = do_QueryObject(aChild); // If the given child is not treeitem then it should be treecols accessible. if (!item) return nsAccessible::GetIndexOf(aChild); return nsAccessible::GetChildCount() + item->GetRowIndex(); } @@ -627,18 +625,17 @@ nsXULTreeAccessible::TreeViewInvalidated } for (PRInt32 rowIdx = aStartRow; rowIdx <= endRow; ++rowIdx) { void *key = reinterpret_cast<void*>(rowIdx); nsAccessible *accessible = mAccessibleCache.GetWeak(key); if (accessible) { - nsRefPtr<nsXULTreeItemAccessibleBase> treeitemAcc = - nsAccUtils::QueryObject<nsXULTreeItemAccessibleBase>(accessible); + nsRefPtr<nsXULTreeItemAccessibleBase> treeitemAcc = do_QueryObject(accessible); NS_ASSERTION(treeitemAcc, "Wrong accessible at the given key!"); treeitemAcc->RowInvalidated(aStartCol, endCol); } } } void
--- a/accessible/src/xul/nsXULTreeGridAccessible.cpp +++ b/accessible/src/xul/nsXULTreeGridAccessible.cpp @@ -353,18 +353,17 @@ nsXULTreeGridAccessible::GetCellAt(PRInt if (!rowAccessible) return NS_ERROR_INVALID_ARG; nsCOMPtr<nsITreeColumn> column = nsCoreUtils::GetSensibleColumnAt(mTree, aColumnIndex); if (!column) return NS_ERROR_INVALID_ARG; - nsRefPtr<nsXULTreeItemAccessibleBase> rowAcc = - nsAccUtils::QueryObject<nsXULTreeItemAccessibleBase>(rowAccessible); + nsRefPtr<nsXULTreeItemAccessibleBase> rowAcc = do_QueryObject(rowAccessible); NS_IF_ADDREF(*aCell = rowAcc->GetCellAccessible(column)); return NS_OK; } NS_IMETHODIMP nsXULTreeGridAccessible::GetCellIndexAt(PRInt32 aRowIndex, PRInt32 aColumnIndex, PRInt32 *aCellIndex) @@ -700,18 +699,17 @@ nsXULTreeGridRowAccessible::GetChildCoun } PRInt32 nsXULTreeGridRowAccessible::GetIndexOf(nsIAccessible *aChild) { if (IsDefunct()) return -1; - nsRefPtr<nsXULTreeGridCellAccessible> cell = - nsAccUtils::QueryObject<nsXULTreeGridCellAccessible>(aChild); + nsRefPtr<nsXULTreeGridCellAccessible> cell = do_QueryObject(aChild); return cell ? cell->GetColumnIndex() : -1; } //////////////////////////////////////////////////////////////////////////////// // nsXULTreeGridRowAccessible: nsXULTreeItemAccessibleBase implementation nsAccessible* @@ -752,18 +750,17 @@ nsXULTreeGridRowAccessible::RowInvalidat return; for (PRInt32 colIdx = aStartColIdx; colIdx <= aEndColIdx; ++colIdx) { nsCOMPtr<nsITreeColumn> column; treeColumns->GetColumnAt(colIdx, getter_AddRefs(column)); if (column && !nsCoreUtils::IsColumnHidden(column)) { nsAccessible *cellAccessible = GetCellAccessible(column); if (cellAccessible) { - nsRefPtr<nsXULTreeGridCellAccessible> cellAcc = - nsAccUtils::QueryObject<nsXULTreeGridCellAccessible>(cellAccessible); + nsRefPtr<nsXULTreeGridCellAccessible> cellAcc = do_QueryObject(cellAccessible); cellAcc->CellInvalidated(); } } } } //////////////////////////////////////////////////////////////////////////////// @@ -1282,18 +1279,17 @@ nsXULTreeGridCellAccessible::GetSiblingA column = nsCoreUtils::GetNextSensibleColumn(columnAtOffset); column.swap(columnAtOffset); } } if (!columnAtOffset) return nsnull; - nsRefPtr<nsXULTreeItemAccessibleBase> rowAcc = - nsAccUtils::QueryObject<nsXULTreeItemAccessibleBase>(mParent); + nsRefPtr<nsXULTreeItemAccessibleBase> rowAcc = do_QueryObject(mParent); return rowAcc->GetCellAccessible(columnAtOffset); } void nsXULTreeGridCellAccessible::DispatchClickEvent(nsIContent *aContent, PRUint32 aActionIndex) {