Bug 1594982 - Initialize tbpl_status and worst_log_level in RaptorOutputParser; r=perftest-reviewers,sparky
authorGeoff Brown <gbrown@mozilla.com>
Fri, 15 Nov 2019 14:51:11 +0000
changeset 502180 ce76d83dde22c957c75a8f5ab8161170fa762923
parent 502179 6d7fa567184ed7fe82d21e0f629c09d7f285f717
child 502181 a3cf1224284f9177fe2d8a86daab3fd40aa4578b
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersperftest-reviewers, sparky
bugs1594982, 1592681
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594982 - Initialize tbpl_status and worst_log_level in RaptorOutputParser; r=perftest-reviewers,sparky Avoid intermittent failures: "AttributeError: 'RaptorOutputParser' object has no attribute 'tbpl_status'". All mozharness OutputParser-derived classes normally initialize these variables; I neglected to do so in bug 1592681. Differential Revision: https://phabricator.services.mozilla.com/D52675
testing/mozharness/mozharness/mozilla/testing/raptor.py
--- a/testing/mozharness/mozharness/mozilla/testing/raptor.py
+++ b/testing/mozharness/mozharness/mozilla/testing/raptor.py
@@ -15,17 +15,17 @@ import sys
 import subprocess
 
 from shutil import copyfile
 
 import mozharness
 
 from mozharness.base.errors import PythonErrorList
 from mozharness.base.log import OutputParser, DEBUG, ERROR, CRITICAL, INFO
-from mozharness.mozilla.automation import TBPL_RETRY, TBPL_WORST_LEVEL_TUPLE
+from mozharness.mozilla.automation import TBPL_SUCCESS, TBPL_RETRY, TBPL_WORST_LEVEL_TUPLE
 from mozharness.mozilla.testing.android import AndroidMixin
 from mozharness.mozilla.testing.errors import HarnessErrorList, TinderBoxPrintRe
 from mozharness.mozilla.testing.testbase import TestingMixin, testing_config_options
 from mozharness.base.vcs.vcsbase import MercurialScript
 from mozharness.mozilla.testing.codecoverage import (
     CodeCoverageMixin,
     code_coverage_config_options
 )
@@ -759,16 +759,18 @@ class Raptor(TestingMixin, MercurialScri
 class RaptorOutputParser(OutputParser):
     minidump_regex = re.compile(r'''raptorError: "error executing: '(\S+) (\S+) (\S+)'"''')
     RE_PERF_DATA = re.compile(r'.*PERFHERDER_DATA:\s+(\{.*\})')
 
     def __init__(self, **kwargs):
         super(RaptorOutputParser, self).__init__(**kwargs)
         self.minidump_output = None
         self.found_perf_data = []
+        self.tbpl_status = TBPL_SUCCESS
+        self.worst_log_level = INFO
         self.harness_retry_re = TinderBoxPrintRe['harness_error']['retry_regex']
 
     def parse_single_line(self, line):
         m = self.minidump_regex.search(line)
         if m:
             self.minidump_output = (m.group(1), m.group(2), m.group(3))
 
         m = self.RE_PERF_DATA.match(line)