Bug 1318096 part 8. Remove XPCOM element client* APIs. r=froydnj
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 17 Nov 2016 13:49:27 -0500
changeset 323078 cdb9cc8de7a0fcf2d34fb2906788432a07dd95ef
parent 323077 90d39fcf8890e18aa1d805124f68c2027a5f6227
child 323079 a246493b8a5c39ed438b6fb017b2ca8ffb7cc79c
push id84045
push userbzbarsky@mozilla.com
push dateThu, 17 Nov 2016 18:49:45 +0000
treeherdermozilla-inbound@4d5f785bc4b4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1318096
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1318096 part 8. Remove XPCOM element client* APIs. r=froydnj
dom/base/Element.h
dom/interfaces/core/nsIDOMElement.idl
--- a/dom/base/Element.h
+++ b/dom/base/Element.h
@@ -1795,40 +1795,10 @@ NS_IMETHOD GetChildElementCount(uint32_t
 {                                                                             \
   *aChildElementCount = Element::ChildElementCount();                         \
   return NS_OK;                                                               \
 }                                                                             \
 NS_IMETHOD MozRemove() final override                                         \
 {                                                                             \
   nsINode::Remove();                                                          \
   return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetClientRects(nsIDOMClientRectList** _retval) final override      \
-{                                                                             \
-  *_retval = Element::GetClientRects().take();                                \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetBoundingClientRect(nsIDOMClientRect** _retval) final override   \
-{                                                                             \
-  *_retval = Element::GetBoundingClientRect().take();                         \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetClientTop(int32_t* aClientTop) final override                   \
-{                                                                             \
-  *aClientTop = Element::ClientTop();                                         \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetClientLeft(int32_t* aClientLeft) final override                 \
-{                                                                             \
-  *aClientLeft = Element::ClientLeft();                                       \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetClientWidth(int32_t* aClientWidth) final override               \
-{                                                                             \
-  *aClientWidth = Element::ClientWidth();                                     \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetClientHeight(int32_t* aClientHeight) final override             \
-{                                                                             \
-  *aClientHeight = Element::ClientHeight();                                   \
-  return NS_OK;                                                               \
 }
 #endif // mozilla_dom_Element_h__
--- a/dom/interfaces/core/nsIDOMElement.idl
+++ b/dom/interfaces/core/nsIDOMElement.idl
@@ -86,59 +86,9 @@ interface nsIDOMElement : nsIDOMNode
   readonly attribute nsIDOMElement nextElementSibling;
   /**
    * Returns the number of child nodes that are nsIDOMElements.
    */
   readonly attribute unsigned long childElementCount;
 
   [binaryname(MozRemove)]
   void remove();
-
-  // CSSOM View
-  /**
-   * Retrieve a list of rectangles, one for each CSS border-box associated with
-   * the element. The coordinates are in CSS pixels, and relative to
-   * the top-left of the document's viewport, unless the document
-   * has an SVG foreignobject ancestor, in which case the coordinates are
-   * relative to the top-left of the content box of the nearest SVG foreignobject
-   * ancestor. The coordinates are calculated as if every scrollable element
-   * is scrolled to its default position.
-   *
-   * Note: the boxes of overflowing children do not affect these rectangles.
-   * Note: some elements have empty CSS boxes. Those return empty rectangles,
-   * but the coordinates may still be meaningful.
-   * Note: some elements have no CSS boxes (including display:none elements,
-   * HTML AREA elements, and SVG elements that do not render). Those return
-   * an empty list.
-   */
-  nsIDOMClientRectList getClientRects();
-
-  /**
-   * Returns the union of all rectangles in the getClientRects() list. Empty
-   * rectangles are ignored, except that if all rectangles are empty,
-   * we return an empty rectangle positioned at the top-left of the first
-   * rectangle in getClientRects().
-   */
-  nsIDOMClientRect getBoundingClientRect();
-
-  /**
-   * The height in CSS pixels of the element's top border.
-   */
-  readonly attribute long             clientTop;
-
-  /**
-   * The width in CSS pixels of the element's left border and scrollbar
-   * if it is present on the left side.
-   */
-  readonly attribute long             clientLeft;
-
-  /**
-   * The height in CSS pixels of the element's padding box. If the element is
-   * scrollable, the scroll bars are included inside this width.
-   */
-  readonly attribute long             clientWidth;
-
-  /**
-   * The width in CSS pixels of the element's padding box. If the element is
-   * scrollable, the scroll bars are included inside this height.
-   */
-  readonly attribute long             clientHeight;
 };