Bug 1224019 - Disable Stagefright subset gtests - r=jya, rs=botond
authorGerald Squelart <gsquelart@mozilla.com>
Wed, 11 Nov 2015 19:24:48 -0500
changeset 272160 cdb6a1c38b89dd372111e2097a49553fc5f3279a
parent 272159 2f3625e34e063228a65439ac388f10a71cba9b1f
child 272161 f00a24682d57e48a287e11bcfc72e562929fd007
push id67897
push userbballo@mozilla.com
push dateThu, 12 Nov 2015 00:25:40 +0000
treeherdermozilla-inbound@cdb6a1c38b89 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya, botond
bugs1224019
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1224019 - Disable Stagefright subset gtests - r=jya, rs=botond These tests are exploratory, they don't particularly match whatever the original issues were discovered, so it is safe to disable them for now. A future bug will look at re-enabling them, but without all the output that they generate.
media/libstagefright/gtest/TestParser.cpp
--- a/media/libstagefright/gtest/TestParser.cpp
+++ b/media/libstagefright/gtest/TestParser.cpp
@@ -235,16 +235,18 @@ TEST(stagefright_MPEG4Metadata, test_cas
     EXPECT_FALSE(metadata.GetTrackInfo(TrackInfo::kTextTrack, 0));
     EXPECT_FALSE(metadata.GetTrackInfo(static_cast<TrackInfo::TrackType>(-1), 0));
     // We can see anywhere in any MPEG4.
     EXPECT_TRUE(metadata.CanSeek());
     EXPECT_FALSE(metadata.Crypto().valid);
   }
 }
 
+// Bug 1224019: This test produces way to much output, disabling for now.
+#if 0
 TEST(stagefright_MPEG4Metadata, test_case_mp4_subsets)
 {
   static const size_t step = 1u;
   for (size_t test = 0; test < ArrayLength(testFiles); ++test) {
     nsTArray<uint8_t> buffer = ReadTestFile(testFiles[test].mFilename);
     ASSERT_FALSE(buffer.IsEmpty());
     ASSERT_LE(step, buffer.Length());
     // Just exercizing the parser starting at different points through the file,
@@ -270,16 +272,17 @@ TEST(stagefright_MPEG4Metadata, test_cas
         } else {
           // Read up to the end (or after?!) -> Just cut 1 byte.
           size -= 1;
         }
       }
     }
   }
 }
+#endif
 
 TEST(stagefright_MoofParser, test_case_mp4)
 {
   for (size_t test = 0; test < ArrayLength(testFiles); ++test) {
     nsTArray<uint8_t> buffer = ReadTestFile(testFiles[test].mFilename);
     ASSERT_FALSE(buffer.IsEmpty());
     RefPtr<Stream> stream = new TestStream(buffer.Elements(), buffer.Length());
 
@@ -300,16 +303,18 @@ TEST(stagefright_MoofParser, test_case_m
     EXPECT_TRUE(parser.HasMetadata());
     RefPtr<MediaByteBuffer> metadataBuffer = parser.Metadata();
     EXPECT_TRUE(metadataBuffer);
     EXPECT_TRUE(parser.FirstCompleteMediaSegment().IsNull());
     EXPECT_TRUE(parser.FirstCompleteMediaHeader().IsNull());
   }
 }
 
+// Bug 1224019: This test produces way to much output, disabling for now.
+#if 0
 TEST(stagefright_MoofParser, test_case_mp4_subsets)
 {
   const size_t step = 1u;
   for (size_t test = 0; test < ArrayLength(testFiles); ++test) {
     nsTArray<uint8_t> buffer = ReadTestFile(testFiles[test].mFilename);
     ASSERT_FALSE(buffer.IsEmpty());
     ASSERT_LE(step, buffer.Length());
     Monitor monitor("MP4Metadata::HasCompleteMetadata");
@@ -343,16 +348,17 @@ TEST(stagefright_MoofParser, test_case_m
         } else {
           // Read up to the end (or after?!) -> Just cut 1 byte.
           size -= 1;
         }
       }
     }
   }
 }
+#endif
 
 uint8_t media_libstagefright_gtest_video_init_mp4[] = {
   0x00, 0x00, 0x00, 0x18, 0x66, 0x74, 0x79, 0x70, 0x69, 0x73, 0x6f, 0x6d,
   0x00, 0x00, 0x00, 0x01, 0x69, 0x73, 0x6f, 0x6d, 0x61, 0x76, 0x63, 0x31,
   0x00, 0x00, 0x02, 0xd1, 0x6d, 0x6f, 0x6f, 0x76, 0x00, 0x00, 0x00, 0x6c,
   0x6d, 0x76, 0x68, 0x64, 0x00, 0x00, 0x00, 0x00, 0xc8, 0x49, 0x73, 0xf8,
   0xc8, 0x4a, 0xc5, 0x7a, 0x00, 0x00, 0x02, 0x58, 0x00, 0x00, 0x00, 0x00,
   0x00, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,