Bug 1277456 part 1 - Store the parent document object of AnimationEffectReadOnly as an nsIDocument rather than nsISupports; r=hiro
authorBrian Birtles <birtles@gmail.com>
Wed, 13 Jul 2016 11:32:01 +0900
changeset 305205 cd6cf16dfb746cd977f93874e8d2005cd51cd3d0
parent 305204 de45aca6e7cfd90777cfcb1524443039e1d22374
child 305206 5ccd87793088302d581393c8681f77b08dbadf3d
push id79518
push usercbook@mozilla.com
push dateSun, 17 Jul 2016 08:09:59 +0000
treeherdermozilla-inbound@711963e8daa3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1277456
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1277456 part 1 - Store the parent document object of AnimationEffectReadOnly as an nsIDocument rather than nsISupports; r=hiro MozReview-Commit-ID: 2GQvDB1rhoA
dom/animation/AnimationEffectReadOnly.cpp
dom/animation/AnimationEffectReadOnly.h
--- a/dom/animation/AnimationEffectReadOnly.cpp
+++ b/dom/animation/AnimationEffectReadOnly.cpp
@@ -5,17 +5,17 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "mozilla/dom/AnimationEffectReadOnly.h"
 #include "mozilla/dom/AnimationEffectReadOnlyBinding.h"
 
 namespace mozilla {
 namespace dom {
 
-NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(AnimationEffectReadOnly, mParent)
+NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(AnimationEffectReadOnly, mDocument)
 
 NS_IMPL_CYCLE_COLLECTING_ADDREF(AnimationEffectReadOnly)
 NS_IMPL_CYCLE_COLLECTING_RELEASE(AnimationEffectReadOnly)
 
 NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(AnimationEffectReadOnly)
   NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
   NS_INTERFACE_MAP_ENTRY(nsISupports)
 NS_INTERFACE_MAP_END
--- a/dom/animation/AnimationEffectReadOnly.h
+++ b/dom/animation/AnimationEffectReadOnly.h
@@ -19,30 +19,30 @@ struct ComputedTimingProperties;
 
 class AnimationEffectReadOnly : public nsISupports,
                                 public nsWrapperCache
 {
 public:
   NS_DECL_CYCLE_COLLECTING_ISUPPORTS
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(AnimationEffectReadOnly)
 
-  explicit AnimationEffectReadOnly(nsISupports* aParent)
-    : mParent(aParent)
+  explicit AnimationEffectReadOnly(nsIDocument* aDocument)
+    : mDocument(aDocument)
   {
   }
 
-  nsISupports* GetParentObject() const { return mParent; }
+  nsISupports* GetParentObject() const { return mDocument; }
 
   virtual already_AddRefed<AnimationEffectTimingReadOnly> Timing() const = 0;
 
   virtual void GetComputedTimingAsDict(ComputedTimingProperties& aRetVal) const = 0;
 
 protected:
   virtual ~AnimationEffectReadOnly() = default;
 
 protected:
-  nsCOMPtr<nsISupports> mParent;
+  RefPtr<nsIDocument> mDocument;
 };
 
 } // namespace dom
 } // namespace mozilla
 
 #endif // mozilla_dom_AnimationEffectReadOnly_h