Bug 1161831 - Stop using threaddsafe ISupports for nsResProtocolHandler. r=billm
authorBobby Holley <bobbyholley@gmail.com>
Fri, 17 Jul 2015 14:40:21 -0700
changeset 253942 cd49cae74a81362ffca63066f65a6bc345dbd2b3
parent 253941 f659ec819bf6ecdeb04da10b00f3404ef6768a09
child 253943 7b078b5605a1bc51ba7fb87b5b81f46f9e8dfad1
push id62606
push userbobbyholley@gmail.com
push dateTue, 21 Jul 2015 19:57:56 +0000
treeherdermozilla-inbound@a37164c4c1bb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbillm
bugs1161831
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1161831 - Stop using threaddsafe ISupports for nsResProtocolHandler. r=billm As far as I can tell, this thing isn't threadsafe at all.
netwerk/protocol/res/nsResProtocolHandler.h
--- a/netwerk/protocol/res/nsResProtocolHandler.h
+++ b/netwerk/protocol/res/nsResProtocolHandler.h
@@ -22,17 +22,17 @@ public:
     virtual nsStandardURL* StartClone();
     virtual nsresult EnsureFile();
     NS_IMETHOD GetClassIDNoAlloc(nsCID *aCID);
 };
 
 class nsResProtocolHandler final : public nsIResProtocolHandler, public nsSupportsWeakReference
 {
 public:
-    NS_DECL_THREADSAFE_ISUPPORTS
+    NS_DECL_ISUPPORTS
     NS_DECL_NSIPROTOCOLHANDLER
     NS_DECL_NSIRESPROTOCOLHANDLER
 
     nsResProtocolHandler();
 
     nsresult Init();
 
     void CollectSubstitutions(InfallibleTArray<ResourceMapping>& aResources);