Bug 1526562 - Specify location correctly in replaying log point messages, r=lsmyth.
authorBrian Hackett <bhackett1024@gmail.com>
Fri, 08 Feb 2019 14:43:26 -1000
changeset 459556 cb355b458bbf165b878f9ea76c09145a8c29f4c1
parent 459555 57243d949492189c7094607a352f27a4c31b8dc7
child 459557 b845c53036f494719110f400338dcae05031039f
push id111966
push userbhackett@mozilla.com
push dateFri, 15 Feb 2019 19:58:44 +0000
treeherdermozilla-inbound@cb355b458bbf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslsmyth
bugs1526562
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526562 - Specify location correctly in replaying log point messages, r=lsmyth.
devtools/client/webconsole/webconsole-connection-proxy.js
--- a/devtools/client/webconsole/webconsole-connection-proxy.js
+++ b/devtools/client/webconsole/webconsole-connection-proxy.js
@@ -307,25 +307,32 @@ WebConsoleConnectionProxy.prototype = {
    */
   _onConsoleAPICall: function(type, packet) {
     if (!this.webConsoleUI || packet.from != this.webConsoleClient.actor) {
       return;
     }
     this.dispatchMessageAdd(packet);
   },
 
+  /**
+   * Virtual console log packets come from log point hits and are converted into
+   * normal console API packets.
+   */
   _onVirtualConsoleLog: function(type, packet) {
     if (!this.webConsoleUI) {
       return;
     }
     this.dispatchMessageAdd({
       type: "consoleAPICall",
       message: {
         executionPoint: packet.executionPoint,
-        "arguments": [packet.url + ":" + packet.line, packet.message],
+        "arguments": [packet.message],
+        filename: packet.url,
+        lineNumber: packet.line,
+        columnNumber: packet.column,
       },
     });
   },
 
   /**
    * The "networkEvent" message type handler. We redirect any message to
    * the UI for displaying.
    *