Bug 1069652 (Followup) - Fix a comment that was totally wrong. r=me DONTBUILD
authorSeth Fowler <seth@mozilla.com>
Tue, 23 Sep 2014 16:17:35 -0700
changeset 206792 caeb5176aeca1b2f10d6177cb6934b6c44381046
parent 206791 d62a8389ca0a874be0b42af4138c78aec8689269
child 206793 709cc1dcd23d5b8171e2f6b1391229cd47d6bb14
push id49517
push usermfowler@mozilla.com
push dateTue, 23 Sep 2014 23:17:59 +0000
treeherdermozilla-inbound@caeb5176aeca [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1069652
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1069652 (Followup) - Fix a comment that was totally wrong. r=me DONTBUILD
image/src/imgFrame.cpp
--- a/image/src/imgFrame.cpp
+++ b/image/src/imgFrame.cpp
@@ -406,19 +406,20 @@ nsresult imgFrame::Optimize()
 
   if (mOptSurface) {
     mVBuf = nullptr;
     mVBufPtr = nullptr;
     mImageSurface = nullptr;
   }
 
 #ifdef MOZ_WIDGET_ANDROID
-  // On Android, free mImageSurface unconditionally if we're discardable.
+  // On Android, free mImageSurface unconditionally if we're discardable. This
+  // allows the operating system to free our volatile buffer.
   // XXX(seth): We'd eventually like to do this on all platforms, but right now
-  // we'd read back from the GPU too much to make it worthwhile.
+  // converting raw memory to a SourceSurface is expensive on some backends.
   if (mDiscardable) {
     mImageSurface = nullptr;
   }
 #endif
 
   return NS_OK;
 }