Bug 1494789 - Use --error-color for warning and error objectBox-string. r=nchevobbe
authorKristin Taylor <comecloserandsee@gmail.com>
Mon, 05 Nov 2018 20:37:00 +0200
changeset 444491 c9bec25613467c1797fbf2df08d5828a73afda48
parent 444490 e0782f3375486ed17b7e0ed251845b3578d7927d
child 444598 bd0ce1c2d8f6afadecc36a17ba6f8512e2717f4e
push id109602
push userrgurzau@mozilla.com
push dateTue, 06 Nov 2018 07:53:38 +0000
treeherdermozilla-inbound@c9bec2561346 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1494789
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1494789 - Use --error-color for warning and error objectBox-string. r=nchevobbe MozReview-Commit-ID: HoZCxaa8udF
devtools/client/themes/webconsole.css
--- a/devtools/client/themes/webconsole.css
+++ b/devtools/client/themes/webconsole.css
@@ -649,16 +649,24 @@ a.learn-more-link.webconsole-learn-more-
   margin-inline-start: 0.5em;
 }
 
 /* Special casing String reps so they are legible */
 .webconsole-output-wrapper .message .message-body > .objectBox-string {
   color: currentColor;
 }
 
+/* Special casing warning and error string colors so they are legible */
+.theme-dark .message.error .objectBox-string,
+.theme-light .message.error .objectBox-string,
+.theme-dark .message.warn .objectBox-string,
+.theme-light .message.warn .objectBox-string {
+  color: var(--error-color);
+}
+
 /* Special casing dark-theme error and warning ObjectInspector colors */
 .theme-dark .webconsole-output-wrapper .message.error .tree.object-inspector .object-label,
 .theme-dark .webconsole-output-wrapper .message.error .tree.object-inspector .object-label *,
 .theme-dark .webconsole-output-wrapper .message.warn .tree.object-inspector .object-label,
 .theme-dark .webconsole-output-wrapper .message.warn .tree.object-inspector .object-label *,
 .theme-dark .webconsole-output-wrapper .message.error .objectLeftBrace,
 .theme-dark .webconsole-output-wrapper .message.error .objectRightBrace,
 .theme-dark .webconsole-output-wrapper .message.error .arrayLeftBracket,