Bug 1043695 - Try passing zero for DTS instead of PTS. r=cpearce
authorRalph Giles <giles@mozilla.com>
Thu, 24 Jul 2014 16:58:00 -0700
changeset 196827 c62d33eb57d3b870cdc167c0cac1b442a36554d9
parent 196826 a140fa9605f0cf1f3c2e92ea79d09545204489d5
child 196828 26b80b058cd245285439408c388cb990ef3a4136
push id46977
push userrgiles@mozilla.com
push dateWed, 30 Jul 2014 16:59:13 +0000
treeherdermozilla-inbound@dc0fbe8b84d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpearce
bugs1043695
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1043695 - Try passing zero for DTS instead of PTS. r=cpearce Suggestion from ajones to make it fail more obviously if the lack of DTS values causes a problem. Doesn't seem to make a difference.
content/media/fmp4/apple/AppleVTDecoder.cpp
--- a/content/media/fmp4/apple/AppleVTDecoder.cpp
+++ b/content/media/fmp4/apple/AppleVTDecoder.cpp
@@ -279,18 +279,17 @@ static CMSampleTimingInfo
 TimingInfoFromSample(mp4_demuxer::MP4Sample* aSample)
 {
   CMSampleTimingInfo timestamp;
 
   timestamp.duration = CMTimeMake(aSample->duration, USECS_PER_S);
   timestamp.presentationTimeStamp =
     CMTimeMake(aSample->composition_timestamp, USECS_PER_S);
   // No DTS value available from libstagefright.
-  timestamp.decodeTimeStamp =
-    CMTimeMake(aSample->composition_timestamp, USECS_PER_S);
+  timestamp.decodeTimeStamp = CMTimeMake(0, USECS_PER_S);
 
   return timestamp;
 }
 
 nsresult
 AppleVTDecoder::SubmitFrame(mp4_demuxer::MP4Sample* aSample)
 {
   // For some reason this gives me a double-free error with stagefright.