Bug 1158540 follow-up: Improve the comment
authorEhsan Akhgari <ehsan@mozilla.com>
Mon, 27 Apr 2015 09:17:24 -0400
changeset 241195 c5bada9c3efe6713cf60397b5e26aa5255eea96a
parent 241194 bcfc39710995094702310c5a54552feebf5972f3
child 241196 ca1ae21cc8e0bac03349cf7a1c7b3979fb60c3f3
push id59042
push usereakhgari@mozilla.com
push dateMon, 27 Apr 2015 13:17:32 +0000
treeherdermozilla-inbound@c5bada9c3efe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1158540
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1158540 follow-up: Improve the comment DONTBUILD
layout/style/nsCSSValue.h
--- a/layout/style/nsCSSValue.h
+++ b/layout/style/nsCSSValue.h
@@ -132,17 +132,19 @@ struct ImageValue : public URLValue {
 private:
   ~ImageValue();
 
 public:
   // Inherit operator== from URLValue
 
   nsRefPtrHashtable<nsPtrHashKey<nsISupports>, imgRequestProxy> mRequests; 
 
-  // Override AddRef and Release to log ourselves correctly.
+  // Override AddRef and Release to not only log ourselves correctly, but
+  // also so that we delete correctly without a virtual destructor (assuming
+  // callers always call *our* Release method and not our base class's).
   NS_METHOD_(MozExternalRefCountType) AddRef();
   NS_METHOD_(MozExternalRefCountType) Release();
 };
 
 struct GridNamedArea {
   nsString mName;
   uint32_t mColumnStart;
   uint32_t mColumnEnd;