Bug 1141710, part 10 - Update some assertion text and comments. r=birtles
authorJonathan Watt <jwatt@jwatt.org>
Thu, 05 Mar 2015 13:07:19 +0000
changeset 232968 c4f66ce3b461bb5d0403e84f40471346b01f58cb
parent 232967 94a0b2bdf4de594b8b88324f036ad6b4ffd92d04
child 232969 1ea7a664602706f28c00e3bef10428a9b44aa54c
push id56704
push userjwatt@jwatt.org
push dateWed, 11 Mar 2015 07:21:06 +0000
treeherdermozilla-inbound@685afe4932f7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs1141710
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1141710, part 10 - Update some assertion text and comments. r=birtles
dom/animation/test/css-animations/test_animation-player-starttime.html
--- a/dom/animation/test/css-animations/test_animation-player-starttime.html
+++ b/dom/animation/test/css-animations/test_animation-player-starttime.html
@@ -298,17 +298,18 @@ function checkStateAtActiveIntervalEndTi
   assert_equals(player.source.target.style.animationPlayState, "running",
     'AnimationPlayer.source.target.style.animationPlayState should be ' +
     '"finished" at the end of the active interval');
 
   var div = player.source.target;
   var marginLeft = parseFloat(getComputedStyle(div).marginLeft);
   assert_equals(marginLeft, UNANIMATED_POSITION,
     'the computed value of margin-left should be unaffected ' +
-    'by the animation at the end of the active duration');
+    'by the animation at the end of the active duration when the ' +
+    'animation-fill-mode is none');
 }
 
 
 test(function(t)
 {
   var div = addDiv(t, {'class': 'animated-div'});
 
   div.style.animation = ANIM_PROPERTY_VAL;
@@ -335,17 +336,17 @@ test(function(t)
   // the past or is resolved in the future.
 
   var currentTime = player.timeline.currentTime;
   player.startTime = currentTime;
   assert_approx_equals(player.startTime, currentTime, 0.0001, // rounding error
     'Check setting of startTime actually works');
 
   checkStateOnSettingStartTimeToAnimationCreationTime(player);
-}, 'Examine newly created Animation');
+}, 'Sanity test to check round-tripping assigning to new animation\'s startTime');
 
 
 async_test(function(t) {
   var div = addDiv(t, {'class': 'animated-div'});
   var eventWatcher = new EventWatcher(div, CSS_ANIM_EVENTS);
 
   div.style.animation = ANIM_PROPERTY_VAL;
 
@@ -577,16 +578,18 @@ async_test(function(t) {
 
   player.ready.then(t.step_func(function() {
     var savedStartTime = player.startTime;
 
     assert_not_equals(player.startTime, null,
       'AnimationPlayer.startTime not null on ready Promise resolve');
 
     player.pause();
+    // After bug 1109390 we will need to wait here for the ready promise again
+
     assert_equals(player.startTime, null,
       'AnimationPlayer.startTime is null after paused');
     assert_equals(player.playState, 'paused',
       'AnimationPlayer.playState is "paused" after pause() call');
   })).catch(t.step_func(function(reason) {
     assert_unreached(reason);
   })).then(function() {
     t.done();