Bug 1597072 - Make sure we have an error if necko have not closed a Http3Session, but neqo has closed it r=agrover
authorDragana Damjanovic <dd.mozilla@gmail.com>
Sun, 17 Nov 2019 03:28:35 +0000
changeset 502330 c4a8c476bbe5a63a86298d6b13858740f3261d80
parent 502329 4def8673359ed4962794b4869019539451f78f15
child 502331 69773bf582aaf07359f93e043c45728bb2224b31
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersagrover
bugs1597072
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1597072 - Make sure we have an error if necko have not closed a Http3Session, but neqo has closed it r=agrover Differential Revision: https://phabricator.services.mozilla.com/D53328
netwerk/protocol/http/Http3Session.cpp
--- a/netwerk/protocol/http/Http3Session.cpp
+++ b/netwerk/protocol/http/Http3Session.cpp
@@ -323,16 +323,19 @@ nsresult Http3Session::ProcessEvents(uin
         LOG(("Http3Session::ProcessEvents - ConnectionClosing"));
         if (NS_SUCCEEDED(mError) && !IsClosing()) {
           mError = NS_ERROR_NET_HTTP3_PROTOCOL_ERROR;
         }
         CloseInternal(false);
         break;
       case Http3Event::Tag::ConnectionClosed:
         LOG(("Http3Session::ProcessEvents - ConnectionClosed"));
+        if (NS_SUCCEEDED(mError) && !IsClosing()) {
+          mError = NS_ERROR_NET_HTTP3_PROTOCOL_ERROR;
+        }
         CloseInternal(false);
         mState = CLOSED;
         break;
       default:
         break;
     }
     event = mHttp3Connection->GetEvent();
   }