Bug 1061274 - Do not pass a non-POD object to a variadic function in nsTextStore::MouseTracker::UnadviseSink; r=masayuki
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 02 Sep 2014 09:48:27 -0400
changeset 202989 c39a515d549203fa364af72084971f825c9f1806
parent 202988 2754e0ac36f8fba1f419f670f631eb27a1f325c9
child 202990 342446253776ec883736dfa4b8a47c9186a2d856
push id48544
push usereakhgari@mozilla.com
push dateTue, 02 Sep 2014 13:58:34 +0000
treeherdermozilla-inbound@d42caa7bcaca [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmasayuki
bugs1061274
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1061274 - Do not pass a non-POD object to a variadic function in nsTextStore::MouseTracker::UnadviseSink; r=masayuki clang-cl treats this as a fatal error, but MSVC seems fine with it.
widget/windows/nsTextStore.cpp
--- a/widget/windows/nsTextStore.cpp
+++ b/widget/windows/nsTextStore.cpp
@@ -4822,17 +4822,17 @@ nsTextStore::MouseTracker::AdviseSink(ns
 }
 
 void
 nsTextStore::MouseTracker::UnadviseSink()
 {
   PR_LOG(sTextStoreLog, PR_LOG_DEBUG,
          ("TSF: 0x%p   nsTextStore::MouseTracker::UnadviseSink(), "
           "mCookie=%d, mSink=0x%p, mStart=%d, mLength=%d",
-          this, mCookie, mSink, mStart, mLength));
+          this, mCookie, mSink.get(), mStart, mLength));
   mSink = nullptr;
   mStart = mLength = -1;
 }
 
 bool
 nsTextStore::MouseTracker::OnMouseButtonEvent(ULONG aEdge,
                                               ULONG aQuadrant,
                                               DWORD aButtonStatus)