Bug 798187 followup. Actually return our newly-created object from dictionary ToObject. r=peterv
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 22 Oct 2012 14:35:08 -0400
changeset 110976 c2a70bac7627
parent 110975 1d2cb3aeb1ac
child 110977 82fd81257b82
push id16847
push userbzbarsky@mozilla.com
push dateMon, 22 Oct 2012 18:35:14 +0000
treeherdermozilla-inbound@c2a70bac7627 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs798187
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 798187 followup. Actually return our newly-created object from dictionary ToObject. r=peterv
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -5549,16 +5549,18 @@ class CGDictionary(CGThing):
             # NOTE: jsids are per-runtime, so don't use them in workers
             ("  if (!initedIds && !InitIds(cx)) {\n"
              "    return false;\n"
              "  }\n" if not self.workers else "") +
             "${toObjectParent}"
             "${ensureObject}"
             "\n"
             "${defineMembers}\n"
+            "\n"
+            "  *vp = JS::ObjectValue(*obj);\n"
             "  return true;\n"
             "}").substitute({
                 "selfName": self.makeClassName(d),
                 "initParent": CGIndenter(CGGeneric(initParent)).define(),
                 "initMembers": "\n\n".join(memberInits),
                 "idInit": CGIndenter(idinit).define(),
                 "isMainThread": toStringBool(not self.workers),
                 "toObjectParent": CGIndenter(CGGeneric(toObjectParent)).define(),