Backed out changeset 1cb87cc6b6a8 (bug 840277)
authorEd Morley <emorley@mozilla.com>
Thu, 14 Feb 2013 10:02:54 +0000
changeset 121875 c2752716d6c8c5fb346e63114a9fbaad30dd41b0
parent 121874 36c8abb302e5e61588237c31bedee8e0187c3ff3
child 121876 f48618e815d1e2aace372f03c1ddb604c6215e64
push id22964
push useremorley@mozilla.com
push dateThu, 14 Feb 2013 10:03:56 +0000
treeherdermozilla-inbound@f48618e815d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs840277
milestone21.0a1
backs out1cb87cc6b6a8481b86da031329f055f42345de7b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 1cb87cc6b6a8 (bug 840277)
dom/ipc/ContentParent.cpp
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -559,32 +559,17 @@ ContentParent::TransformPreallocatedInto
     // TemporarilySetProcessPriorityToForeground() from within
     // ContentChild::AllocPBrowser, but this happens earlier, thus reducing the
     // window in which the child might be killed due to low memory.
     if (Preferences::GetBool("dom.ipc.processPriorityManager.enabled")) {
         SetProcessPriority(base::GetProcId(mSubprocess->GetChildProcessHandle()),
                            PROCESS_PRIORITY_FOREGROUND);
     }
 
-    // Now that we've increased the process's priority from BACKGROUND (where
-    // the preallocated app sits) to something higher, check whether the process
-    // is still alive.  Hopefully the process won't unexpectedly crash after
-    // this point!
-    //
-    // It's not legal to call DidProcessCrash on Windows if the process has not
-    // terminated yet, so we have to skip this check there.
-
-#ifndef XP_WIN
-    bool exited = false;
-    base::DidProcessCrash(&exited, mSubprocess->GetChildProcessHandle());
-    if (exited) {
-        return false;
-    }
-#endif
-
+    // If this fails, the child process died.
     return SendSetProcessPrivileges(aPrivs);
 }
 
 void
 ContentParent::ShutDownProcess()
 {
   if (!mIsDestroyed) {
     const InfallibleTArray<PIndexedDBParent*>& idbParents =