Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester
☠☠ backed out by 4711cd73ee95 ☠ ☠
authorAndreas Tolfsen <ato@mozilla.com>
Thu, 17 Mar 2016 14:57:46 +0000
changeset 289724 c1fb88d419ca6788f6d0594fb6eafe65d42771df
parent 289723 f8c07a51e7ce426f17f3998ed646d9f0300d331c
child 289774 fa5a9df70ca49ab076458059490fb68e27642c9f
push id73981
push useratolfsen@mozilla.com
push dateTue, 22 Mar 2016 11:19:07 +0000
treeherdermozilla-inbound@c1fb88d419ca [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester
bugs1257526
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester Throw unsupported operation errors the same way throughout Marionette. MozReview-Commit-ID: D63gVIeX2qK
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2642,18 +2642,18 @@ GeckoDriver.prototype.getWindowSize = fu
  * Not supported on B2G. The supplied width and height values refer to
  * the window outerWidth and outerHeight values, which include scroll
  * bars, title bars, etc.
  *
  * An error will be returned if the requested window size would result
  * in the window being in the maximized state.
  */
 GeckoDriver.prototype.setWindowSize = function(cmd, resp) {
-  if (this.appName !== "Firefox") {
-    throw new UnsupportedOperationError("Not supported on mobile");
+  if (this.appName != "Firefox") {
+    throw new UnsupportedOperationError();
   }
 
   let width = parseInt(cmd.parameters.width);
   let height = parseInt(cmd.parameters.height);
 
   let win = this.getCurrentWindow();
   if (width >= win.screen.availWidth && height >= win.screen.availHeight) {
     throw new UnsupportedOperationError("Invalid requested size, cannot maximize");
@@ -2665,17 +2665,17 @@ GeckoDriver.prototype.setWindowSize = fu
 /**
  * Maximizes the user agent window as if the user pressed the maximise
  * button.
  *
  * Not Supported on B2G or Fennec.
  */
 GeckoDriver.prototype.maximizeWindow = function(cmd, resp) {
   if (this.appName != "Firefox") {
-    throw new UnsupportedOperationError("Not supported for mobile");
+    throw new UnsupportedOperationError();
   }
 
   let win = this.getCurrentWindow();
   win.moveTo(0,0);
   win.resizeTo(win.screen.availWidth, win.screen.availHeight);
 };
 
 /**