Bug 1388851 - Follow-up to disable parts of browser_webauthn_telemetry.js r=bustage
authorTim Taubert <ttaubert@mozilla.com>
Thu, 14 Sep 2017 23:12:13 +0200
changeset 380922 c115eec567a65b4045b7fce9765525cf79e24042
parent 380921 b3820db371aee902b4b903483b02ba79082951bd
child 380923 0bdbc08e691cff577004591c5d20350941759b96
push id95020
push userttaubert@mozilla.com
push dateThu, 14 Sep 2017 21:12:50 +0000
treeherdermozilla-inbound@c115eec567a6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1388851
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1388851 - Follow-up to disable parts of browser_webauthn_telemetry.js r=bustage
dom/webauthn/tests/browser/browser_webauthn_telemetry.js
--- a/dom/webauthn/tests/browser/browser_webauthn_telemetry.js
+++ b/dom/webauthn/tests/browser/browser_webauthn_telemetry.js
@@ -77,17 +77,17 @@ add_task(async function test_loopback() 
     is(webauthn_used["U2FSignFinish"], 1, "webauthn_used U2FSignFinish scalar should be 1");
     is(webauthn_used["U2FSignAbort"], undefined, "webauthn_used U2FSignAbort scalar must be unset");
     is(webauthn_used["U2FRegisterAbort"], undefined, "webauthn_used U2FRegisterAbort scalar must be unset");
 
     validateHistogramEntryCount("WEBAUTHN_CREATE_CREDENTIAL_MS", 1);
     validateHistogramEntryCount("WEBAUTHN_GET_ASSERTION_MS", 1);
   }
 
-  {
+  /*{
     cleanupTelemetry();
     // Same as test_successful_loopback, but we will swap to using a (non-existent)
     // usb token. This will cause U2FRegisterAbort to fire, but will not execute the
     // Sign function, and no histogram entries will log.
     Services.prefs.setBoolPref("security.webauth.webauthn", true);
     Services.prefs.setBoolPref("security.webauth.webauthn_enable_softtoken", false);
     Services.prefs.setBoolPref("security.webauth.webauthn_enable_usbtoken", true);
 
@@ -97,13 +97,13 @@ add_task(async function test_loopback() 
     ok(webauthn_used, "Scalar keys are set: " + Object.keys(webauthn_used).join(", "));
     is(webauthn_used["U2FRegisterFinish"], undefined, "webauthn_used U2FRegisterFinish must be unset");
     is(webauthn_used["U2FSignFinish"], undefined, "webauthn_used U2FSignFinish scalar must be unset");
     is(webauthn_used["U2FRegisterAbort"], 1, "webauthn_used U2FRegisterAbort scalar should be a 1");
     is(webauthn_used["U2FSignAbort"], undefined, "webauthn_used U2FSignAbort scalar must be unset");
 
     validateHistogramEntryCount("WEBAUTHN_CREATE_CREDENTIAL_MS", 0);
     validateHistogramEntryCount("WEBAUTHN_GET_ASSERTION_MS", 0);
-  }
+  }*/
 
   // There aren't tests for register succeeding and sign failing, as I don't see an easy way to prompt
   // the soft token to fail that way _and_ trigger the Abort telemetry.
 });