Bug 1061058 - Fix more bad implicit constructors in docshell/dom/uriloader; r=smaug
☠☠ backed out by 912065e39dc3 ☠ ☠
authorEhsan Akhgari <ehsan@mozilla.com>
Mon, 01 Sep 2014 18:01:37 -0400
changeset 202828 bdacbf45323811518b27da14222ec6630f72f5b2
parent 202827 da6c71a8f5ae293ea58368d928ff3faf9ef0f1e9
child 202829 4912d451011aba90f1271f8cb2c72d1777191f0e
push id48506
push usereakhgari@mozilla.com
push dateMon, 01 Sep 2014 22:05:00 +0000
treeherdermozilla-inbound@a8cddc6bdffc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1061058
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1061058 - Fix more bad implicit constructors in docshell/dom/uriloader; r=smaug
docshell/base/nsDefaultURIFixup.h
dom/filesystem/FileSystemPermissionRequest.h
uriloader/exthandler/mac/nsMIMEInfoMac.h
uriloader/exthandler/nsMIMEInfoImpl.h
--- a/docshell/base/nsDefaultURIFixup.h
+++ b/docshell/base/nsDefaultURIFixup.h
@@ -40,17 +40,17 @@ private:
 };
 
 class nsDefaultURIFixupInfo : public nsIURIFixupInfo
 {
 public:
     NS_DECL_ISUPPORTS
     NS_DECL_NSIURIFIXUPINFO
 
-    nsDefaultURIFixupInfo(const nsACString& aOriginalInput);
+    explicit nsDefaultURIFixupInfo(const nsACString& aOriginalInput);
 
     friend class nsDefaultURIFixup;
 
 protected:
     virtual ~nsDefaultURIFixupInfo();
 
 private:
     nsCOMPtr<nsISupports> mConsumer;
--- a/dom/filesystem/FileSystemPermissionRequest.h
+++ b/dom/filesystem/FileSystemPermissionRequest.h
@@ -27,17 +27,17 @@ public:
   // Request permission for the given task.
   static void
   RequestForTask(FileSystemTaskBase* aTask);
 
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSICONTENTPERMISSIONREQUEST
   NS_DECL_NSIRUNNABLE
 private:
-  FileSystemPermissionRequest(FileSystemTaskBase* aTask);
+  explicit FileSystemPermissionRequest(FileSystemTaskBase* aTask);
 
   virtual
   ~FileSystemPermissionRequest();
 
   nsCString mPermissionType;
   nsCString mPermissionAccess;
   nsRefPtr<FileSystemTaskBase> mTask;
   nsCOMPtr<nsPIDOMWindow> mWindow;
--- a/uriloader/exthandler/mac/nsMIMEInfoMac.h
+++ b/uriloader/exthandler/mac/nsMIMEInfoMac.h
@@ -4,18 +4,18 @@
 
 #ifndef nsMIMEInfoMac_h_
 #define nsMIMEInfoMac_h_
 
 #include "nsMIMEInfoImpl.h"
 
 class nsMIMEInfoMac : public nsMIMEInfoImpl {
   public:
-    nsMIMEInfoMac(const char* aMIMEType = "") : nsMIMEInfoImpl(aMIMEType) {}
-    nsMIMEInfoMac(const nsACString& aMIMEType) : nsMIMEInfoImpl(aMIMEType) {}
+    explicit nsMIMEInfoMac(const char* aMIMEType = "") : nsMIMEInfoImpl(aMIMEType) {}
+    explicit nsMIMEInfoMac(const nsACString& aMIMEType) : nsMIMEInfoImpl(aMIMEType) {}
     nsMIMEInfoMac(const nsACString& aType, HandlerClass aClass) :
       nsMIMEInfoImpl(aType, aClass) {}
 
     NS_IMETHOD LaunchWithFile(nsIFile* aFile);
   protected:
     virtual nsresult LoadUriInternal(nsIURI *aURI);
 #ifdef DEBUG
     virtual nsresult LaunchDefaultWithFile(nsIFile* aFile) {
--- a/uriloader/exthandler/nsMIMEInfoImpl.h
+++ b/uriloader/exthandler/nsMIMEInfoImpl.h
@@ -62,18 +62,18 @@ class nsMIMEInfoBase : public nsIMIMEInf
     NS_IMETHOD GetPossibleLocalHandlers(nsIArray **_retval); 
 
     enum HandlerClass {
       eMIMEInfo,
       eProtocolInfo
     };
 
     // nsMIMEInfoBase methods
-    nsMIMEInfoBase(const char *aMIMEType = "");
-    nsMIMEInfoBase(const nsACString& aMIMEType);
+    explicit nsMIMEInfoBase(const char *aMIMEType = "");
+    explicit nsMIMEInfoBase(const nsACString& aMIMEType);
     nsMIMEInfoBase(const nsACString& aType, HandlerClass aClass);
 
     void SetMIMEType(const nsACString & aMIMEType) { mSchemeOrType = aMIMEType; }
 
     void SetDefaultDescription(const nsString& aDesc) { mDefaultAppDescription = aDesc; }
 
     /**
      * Copies basic data of this MIME Info Implementation to the given other
@@ -154,18 +154,18 @@ class nsMIMEInfoBase : public nsIMIMEInf
  * methods. However, depending on your platform you may want to use a different
  * way of launching applications. This class stores the default application in a
  * member variable and provides a function for setting it. For local
  * applications, launching is done using nsIProcess, native path of the file to
  * open as first argument.
  */
 class nsMIMEInfoImpl : public nsMIMEInfoBase {
   public:
-    nsMIMEInfoImpl(const char *aMIMEType = "") : nsMIMEInfoBase(aMIMEType) {}
-    nsMIMEInfoImpl(const nsACString& aMIMEType) : nsMIMEInfoBase(aMIMEType) {}
+    explicit nsMIMEInfoImpl(const char *aMIMEType = "") : nsMIMEInfoBase(aMIMEType) {}
+    explicit nsMIMEInfoImpl(const nsACString& aMIMEType) : nsMIMEInfoBase(aMIMEType) {}
     nsMIMEInfoImpl(const nsACString& aType, HandlerClass aClass) :
       nsMIMEInfoBase(aType, aClass) {}
     virtual ~nsMIMEInfoImpl() {}
 
     // nsIMIMEInfo methods
     NS_IMETHOD GetHasDefaultHandler(bool *_retval);
     NS_IMETHOD GetDefaultDescription(nsAString& aDefaultDescription);