Bug 1479970 - Remove IonBuilder::traceLogger(). r=jandem
authorTed Campbell <tcampbell@mozilla.com>
Fri, 12 Apr 2019 09:23:21 +0000
changeset 469271 bd6762543efec64230544fbfa7002a8a24198216
parent 469270 d2dfbfc9da12efbbba43f32e2a8238a5b0120b09
child 469272 2cc7599b9e92b2ff0d17e6f70b6cad4e0efcc8a4
push id112776
push usershindli@mozilla.com
push dateFri, 12 Apr 2019 16:20:17 +0000
treeherdermozilla-inbound@b4501ced5619 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1479970
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1479970 - Remove IonBuilder::traceLogger(). r=jandem This only had one use is inconsistent with other tracelogger users. Differential Revision: https://phabricator.services.mozilla.com/D27103
js/src/jit/IonBuilder.cpp
js/src/jit/IonBuilder.h
--- a/js/src/jit/IonBuilder.cpp
+++ b/js/src/jit/IonBuilder.cpp
@@ -2559,17 +2559,18 @@ AbortReasonOr<Ok> IonBuilder::inspectOpc
 #ifdef DEBUG
   return abort(AbortReason::Disable, "Unsupported opcode: %s", CodeName[op]);
 #else
   return abort(AbortReason::Disable, "Unsupported opcode: %d", op);
 #endif
 }
 
 AbortReasonOr<Ok> IonBuilder::restartLoop(const CFGBlock* cfgHeader) {
-  AutoTraceLog logCompile(traceLogger(), TraceLogger_IonBuilderRestartLoop);
+  AutoTraceLog logCompile(TraceLoggerForCurrentThread(),
+                          TraceLogger_IonBuilderRestartLoop);
 
   spew("New types at loop header, restarting loop body");
 
   if (JitOptions.limitScriptSize) {
     if (++numLoopRestarts_ >= MAX_LOOP_RESTARTS) {
       return abort(AbortReason::Disable,
                    "Aborted while processing control flow");
     }
--- a/js/src/jit/IonBuilder.h
+++ b/js/src/jit/IonBuilder.h
@@ -1007,18 +1007,16 @@ class IonBuilder : public MIRGenerator,
   const JSAtomState& names() { return realm->runtime()->names(); }
 
   bool hadActionableAbort() const {
     MOZ_ASSERT(!actionableAbortScript_ ||
                (actionableAbortPc_ && actionableAbortMessage_));
     return actionableAbortScript_ != nullptr;
   }
 
-  TraceLoggerThread* traceLogger() { return TraceLoggerForCurrentThread(); }
-
   void actionableAbortLocationAndMessage(JSScript** abortScript,
                                          jsbytecode** abortPc,
                                          const char** abortMessage) {
     MOZ_ASSERT(hadActionableAbort());
     *abortScript = actionableAbortScript_;
     *abortPc = actionableAbortPc_;
     *abortMessage = actionableAbortMessage_;
   }