Bug 1425996 - Add in a few more instances of Unused that got missed in the first patch. r=gerald
authorRyan VanderMeulen <ryanvm@gmail.com>
Sat, 23 Dec 2017 16:40:13 -0500
changeset 397386 bc335a5f19e8267d04fb35fc08846714a2376674
parent 397385 f544046a57dab2e69b13474f1b509b496e8117f9
child 397387 2f1023496d39ae6c8810ae78c2ea406ab27c90fc
push id98512
push userryanvm@gmail.com
push dateSat, 23 Dec 2017 21:42:59 +0000
treeherdermozilla-inbound@2f1023496d39 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1425996
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1425996 - Add in a few more instances of Unused that got missed in the first patch. r=gerald
dom/media/ChannelMediaDecoder.cpp
media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
--- a/dom/media/ChannelMediaDecoder.cpp
+++ b/dom/media/ChannelMediaDecoder.cpp
@@ -332,16 +332,17 @@ ChannelMediaDecoder::NotifyDownloadEnded
         res = RefPtr<BaseMediaResource>(mResource),
         duration = mDuration
       ]() {
         auto rate = ComputePlaybackRate(stats, res, duration);
         UpdatePlaybackRate(rate, res);
       });
     nsresult rv = GetStateMachine()->OwnerThread()->Dispatch(r.forget());
     MOZ_DIAGNOSTIC_ASSERT(NS_SUCCEEDED(rv));
+    Unused << rv;
     owner->DownloadSuspended();
     // NotifySuspendedStatusChanged will tell the element that download
     // has been suspended "by the cache", which is true since we never
     // download anything. The element can then transition to HAVE_ENOUGH_DATA.
     owner->NotifySuspendedByCache(true);
   } else if (aStatus == NS_BINDING_ABORTED) {
     // Download has been cancelled by user.
     owner->LoadAborted();
@@ -398,16 +399,17 @@ ChannelMediaDecoder::DurationChanged()
       res = RefPtr<BaseMediaResource>(mResource),
       duration = mDuration
     ]() {
       auto rate = ComputePlaybackRate(stats, res, duration);
       UpdatePlaybackRate(rate, res);
     });
   nsresult rv = GetStateMachine()->OwnerThread()->Dispatch(r.forget());
   MOZ_DIAGNOSTIC_ASSERT(NS_SUCCEEDED(rv));
+  Unused << rv;
 }
 
 void
 ChannelMediaDecoder::DownloadProgressed()
 {
   MOZ_ASSERT(NS_IsMainThread());
   MOZ_DIAGNOSTIC_ASSERT(!IsShutdown());
 
--- a/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
+++ b/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
@@ -573,16 +573,17 @@ public:
   void QueueAudioChunk(TrackRate aRate, const AudioChunk& aChunk, bool aEnabled)
   {
     RefPtr<AudioProxyThread> self = this;
     nsresult rv = mTaskQueue->Dispatch(NS_NewRunnableFunction(
       "AudioProxyThread::QueueAudioChunk", [self, aRate, aChunk, aEnabled]() {
         self->InternalProcessAudioChunk(aRate, aChunk, aEnabled);
       }));
     MOZ_DIAGNOSTIC_ASSERT(NS_SUCCEEDED(rv));
+    Unused << rv;
   }
 
 protected:
   virtual ~AudioProxyThread()
   {
     // Conduits must be released on MainThread, and we might have the last
     // reference We don't need to worry about runnables still trying to access
     // the conduit, since the runnables hold a ref to AudioProxyThread.