Bug 960254 - Part 3: Remove MarkDirty call to avoid confusion. r=jrmuizel
authorBas Schouten <bschouten@mozilla.com>
Thu, 16 Jan 2014 13:17:23 +0100
changeset 163703 bbad01205856e33a3271f74980200b7b841095a4
parent 163702 3ae8e5f144f160596797bd1dccecba9871587c03
child 163704 327d381e24c82ab621dd7e01200121aa8de7eaef
push id38545
push userbschouten@mozilla.com
push dateThu, 16 Jan 2014 13:37:18 +0000
treeherdermozilla-inbound@327d381e24c8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs960254
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 960254 - Part 3: Remove MarkDirty call to avoid confusion. r=jrmuizel
gfx/2d/2D.h
gfx/2d/DataSourceSurfaceWrapper.h
--- a/gfx/2d/2D.h
+++ b/gfx/2d/2D.h
@@ -364,22 +364,16 @@ public:
 
   /* [DEPRECATED]
    * Stride of the surface, distance in bytes between the start of the image
    * data belonging to row y and row y+1. This may be negative.
    * Can return 0 if there was OOM allocating surface data.
    */
   virtual int32_t Stride() = 0;
 
-  /*
-   * This function is called after modifying the data on the source surface
-   * directly through the data pointer.
-   */
-  virtual void MarkDirty() {}
-
   virtual bool Map(MapType, MappedSurface *aMappedSurface)
   {
     aMappedSurface->mData = GetData();
     aMappedSurface->mStride = Stride();
     mIsMapped = true;
     return true;
   }
 
--- a/gfx/2d/DataSourceSurfaceWrapper.h
+++ b/gfx/2d/DataSourceSurfaceWrapper.h
@@ -22,17 +22,16 @@ public:
 
   virtual SurfaceType GetType() const MOZ_OVERRIDE { return SurfaceType::DATA; }
 
   virtual uint8_t *GetData() MOZ_OVERRIDE { return mSurface->GetData(); }
   virtual int32_t Stride() MOZ_OVERRIDE { return mSurface->Stride(); }
   virtual IntSize GetSize() const MOZ_OVERRIDE { return mSurface->GetSize(); }
   virtual SurfaceFormat GetFormat() const MOZ_OVERRIDE { return mSurface->GetFormat(); }
   virtual bool IsValid() const MOZ_OVERRIDE { return mSurface->IsValid(); }
-  virtual void MarkDirty() { mSurface->MarkDirty(); }
 
 private:
   RefPtr<DataSourceSurface> mSurface;
 };
 
 }
 }