Bug 847480 - Remove unused (verified by manual inspection and try) DeprecatedAbs overloads so it's harder for new uses to pop up. r=Ms2ger
authorJeff Walden <jwalden@mit.edu>
Sat, 09 Mar 2013 14:20:14 -0800
changeset 124955 ba0b144c146f277bb9d8782bbfddb95e1c36a1a8
parent 124954 7d6d8029f70f955a6c7e0d2a3745d6987525e4a5
child 124956 9ed8fb86e214033782ebc36c39c984e990167c6e
push id24696
push userjwalden@mit.edu
push dateFri, 15 Mar 2013 17:45:29 +0000
treeherdermozilla-inbound@ba0b144c146f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMs2ger
bugs847480
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 847480 - Remove unused (verified by manual inspection and try) DeprecatedAbs overloads so it's harder for new uses to pop up. r=Ms2ger
mfbt/MathAlgorithms.h
--- a/mfbt/MathAlgorithms.h
+++ b/mfbt/MathAlgorithms.h
@@ -47,30 +47,24 @@ EuclidLCM(IntegerType a, IntegerType b)
   return (a / EuclidGCD(a, b)) * b;
 }
 
 namespace detail {
 
 template<typename T>
 struct AllowDeprecatedAbsFixed : FalseType {};
 
-template<> struct AllowDeprecatedAbsFixed<int8_t> : TrueType {};
-template<> struct AllowDeprecatedAbsFixed<int16_t> : TrueType {};
 template<> struct AllowDeprecatedAbsFixed<int32_t> : TrueType {};
 template<> struct AllowDeprecatedAbsFixed<int64_t> : TrueType {};
 
 template<typename T>
 struct AllowDeprecatedAbs : AllowDeprecatedAbsFixed<T> {};
 
-template<> struct AllowDeprecatedAbs<char> : IntegralConstant<bool, char(-1) < char(0)> {};
-template<> struct AllowDeprecatedAbs<signed char> : TrueType {};
-template<> struct AllowDeprecatedAbs<short> : TrueType {};
 template<> struct AllowDeprecatedAbs<int> : TrueType {};
 template<> struct AllowDeprecatedAbs<long> : TrueType {};
-template<> struct AllowDeprecatedAbs<long long> : TrueType {};
 
 } // namespace detail
 
 // DO NOT USE DeprecatedAbs.  It exists only until its callers can be converted
 // to Abs below, and it will be removed when all callers have been changed.
 template<typename T>
 inline typename mozilla::EnableIf<detail::AllowDeprecatedAbs<T>::value, T>::Type
 DeprecatedAbs(const T t)